Skip to content

CI: 3.8 build #28730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Oct 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
4d277c4
poke at travis
jbrockmendel Oct 1, 2019
56c49ca
troubleshoot
jbrockmendel Oct 1, 2019
439571c
add sudo
jbrockmendel Oct 1, 2019
656e076
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 2, 2019
66db6a6
keep trying
jbrockmendel Oct 2, 2019
80101f5
Add deps file
jbrockmendel Oct 2, 2019
2fce3b5
again
jbrockmendel Oct 2, 2019
4eac026
i said 38
jbrockmendel Oct 2, 2019
ad56fe9
keep trying
jbrockmendel Oct 2, 2019
f4ad020
do the build
jbrockmendel Oct 2, 2019
4f98585
maybe installing will help?
jbrockmendel Oct 2, 2019
209aecd
troubleshoot, disable azure
jbrockmendel Oct 2, 2019
7d39c4d
install using pip
jbrockmendel Oct 2, 2019
c1b692f
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 2, 2019
6c7e0d1
troubleshoot
jbrockmendel Oct 3, 2019
2e28dca
working with just pytest, now try with run_tests
jbrockmendel Oct 3, 2019
b686fbe
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 3, 2019
452e251
restore, try to do stuff conditionally
jbrockmendel Oct 3, 2019
3c8297d
try to guess how conditional syntax works on travis
jbrockmendel Oct 3, 2019
61f69a0
revert
jbrockmendel Oct 3, 2019
5bb2416
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 8, 2019
5439263
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 9, 2019
82dbbb1
try it without conditionals in yaml
jbrockmendel Oct 9, 2019
a33105f
troubleshoot
jbrockmendel Oct 9, 2019
0561294
disable xvfb on 3.8-dev
jbrockmendel Oct 9, 2019
65d3137
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Oct 10, 2019
8cdaaf7
use pip for numpy
jbrockmendel Oct 10, 2019
fcbf921
poke at travis
jbrockmendel Oct 1, 2019
62a1d00
troubleshoot
jbrockmendel Oct 1, 2019
426ba4a
add sudo
jbrockmendel Oct 1, 2019
d93e5a6
keep trying
jbrockmendel Oct 2, 2019
3f84025
Add deps file
jbrockmendel Oct 2, 2019
64da0db
again
jbrockmendel Oct 2, 2019
e6fdeff
i said 38
jbrockmendel Oct 2, 2019
02db7c3
keep trying
jbrockmendel Oct 2, 2019
fbf1421
do the build
jbrockmendel Oct 2, 2019
48f98e9
maybe installing will help?
jbrockmendel Oct 2, 2019
fd49724
troubleshoot, disable azure
jbrockmendel Oct 2, 2019
611c2b8
install using pip
jbrockmendel Oct 2, 2019
eaa8af7
troubleshoot
jbrockmendel Oct 3, 2019
2d43512
working with just pytest, now try with run_tests
jbrockmendel Oct 3, 2019
ea5aba6
restore, try to do stuff conditionally
jbrockmendel Oct 3, 2019
620023a
try to guess how conditional syntax works on travis
jbrockmendel Oct 3, 2019
e7cdbc6
revert
jbrockmendel Oct 3, 2019
e8c579d
try it without conditionals in yaml
jbrockmendel Oct 9, 2019
a3c986b
troubleshoot
jbrockmendel Oct 9, 2019
8f4a80a
disable xvfb on 3.8-dev
jbrockmendel Oct 9, 2019
3c91ef3
Merge branch 'build38' of github.com:jbrockmendel/pandas into build38
jbrockmendel Oct 10, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ matrix:
- python: 3.5

include:
- dist: bionic
# 18.04
python: 3.8-dev
env:
- JOB="3.8-dev" PATTERN="(not slow and not network)"

- dist: trusty
env:
- JOB="3.7" ENV_FILE="ci/deps/travis-37.yaml" PATTERN="(not slow and not network)"
Expand Down Expand Up @@ -71,24 +77,27 @@ before_install:
# This overrides travis and tells it to look nowhere.
- export BOTO_CONFIG=/dev/null


install:
- echo "install start"
- ci/prep_cython_cache.sh
- ci/setup_env.sh
- ci/submit_cython_cache.sh
- echo "install done"


before_script:
# display server (for clipboard functionality) needs to be started here,
# does not work if done in install:setup_env.sh (GH-26103)
- export DISPLAY=":99.0"
- echo "sh -e /etc/init.d/xvfb start"
- sh -e /etc/init.d/xvfb start
- if [ "$JOB" != "3.8-dev" ]; then sh -e /etc/init.d/xvfb start; fi
- sleep 3

script:
- echo "script start"
- source activate pandas-dev
- echo "$JOB"
- if [ "$JOB" != "3.8-dev" ]; then source activate pandas-dev; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not also called pandas-dev (the env name)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean $JOB? none of the other $JOB values have pandas-dev in the name

- ci/run_tests.sh

after_script:
Expand Down
25 changes: 25 additions & 0 deletions ci/build38.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#!/bin/bash -e
# Special build for python3.8 until numpy puts its own wheels up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should create a bare conda env here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8 should not be very different than a regular setup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be different until there are 3.8 packages (python especially, but also our dependencies).

I think Brock has about the minimal difference we can get right now.

sudo apt-get install build-essential gcc xvfb
pip install --no-deps -U pip wheel setuptools
pip install python-dateutil pytz cython pytest pytest-xdist hypothesis

# Possible alternative for getting numpy:
# pip install --pre -f https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com/ numpy
git clone https://github.com/numpy/numpy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, you can replace this with a pip install --pre -f https://7933911d6844c6c53a7d-47bd50c35cd79bd838daf386af554a83.ssl.cf2.rackcdn.com/ numpy

cd numpy
python setup.py build_ext --inplace
python setup.py install
cd ..
rm -rf numpy

python setup.py build_ext -inplace
python -m pip install --no-build-isolation -e .

python -c "import sys; print(sys.version_info)"
python -c "import pandas as pd"
python -c "import hypothesis"

# TODO: Is there anything else in setup_env that we really want to do?
# ci/setup_env.sh
4 changes: 4 additions & 0 deletions ci/setup_env.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#!/bin/bash -e

if [ "$JOB" == "3.8-dev" ]; then
/bin/bash ci/build38.sh
exit 0
fi

# edit the locale file if needed
if [ -n "$LOCALE_OVERRIDE" ]; then
Expand Down