Skip to content

Setup python 3.8 builds #26626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alimcmaster1 opened this issue Jun 3, 2019 · 5 comments · Fixed by #28730
Closed

Setup python 3.8 builds #26626

alimcmaster1 opened this issue Jun 3, 2019 · 5 comments · Fixed by #28730
Labels
Build Library building on various platforms Needs Discussion Requires discussion from core team before further action
Milestone

Comments

@alimcmaster1
Copy link
Member

As the python 3.8 release date draws closer ( currently scheduled for October this year ).

I was wondering if we want to set up python3.8 builds?

Given the 3.8 dev branch is available on travis and shortly azure.

Might be abit early for this - but it will mean we can catch any potential issues early + support python 3.8 upon release date.

Related issues: #22714

I am happy to work on this - but would be good to get people's thoughts first.

Thanks!

@jreback
Copy link
Contributor

jreback commented Jun 3, 2019

we need it available on conda

as numpy needs to build

@simonjayhawkins simonjayhawkins added Build Library building on various platforms Needs Discussion Requires discussion from core team before further action Python 3.8 labels Jun 3, 2019
@alimcmaster1
Copy link
Member Author

Looks like @h-vetinari kindly started doing this here: conda-forge/python-feedstock#259

@jreback
Copy link
Contributor

jreback commented Jun 3, 2019

well need python numpy and cython then it’s possible
certainly u can push folks

note that once python and cython exists it’s possible to build numpy from source

@h-vetinari
Copy link
Contributor

@alimcmaster1: Looks like @h-vetinari kindly started doing this here: conda-forge/python-feedstock#259

I have been following up on this for a while with the express idea of doing Python 3.8 testing as early as the betas.

Python 3.8.0a3 (conda-forge/python-feedstock#258) worked because one of the maintainers basically did all the work. Although I did a bit more for 3.8.0a4 this time, I haven't had time to properly investigate the build failures - there's a config file that's not found - maybe it moved...? Help is of course appreciated; the conda-forge maintainers have not responded so far (aside from some side issues about 3 weeks back).

In any case, I'll try to pick up the process again as soon as 3.8.0b1 comes out.

jreback added a commit to jreback/pandas that referenced this issue Jul 6, 2019
jreback added a commit to jreback/pandas that referenced this issue Jul 6, 2019
jreback added a commit to jreback/pandas that referenced this issue Jul 6, 2019
jreback added a commit to jreback/pandas that referenced this issue Jul 6, 2019
jreback added a commit to jreback/pandas that referenced this issue Jul 6, 2019
jreback added a commit to jreback/pandas that referenced this issue Jul 6, 2019
jreback added a commit to jreback/pandas that referenced this issue Jul 12, 2019
jreback added a commit to jreback/pandas that referenced this issue Aug 4, 2019
@jreback jreback added this to the 0.25.2 milestone Oct 14, 2019
@jreback
Copy link
Contributor

jreback commented Oct 14, 2019

lgtm; marked for 0.25.2; merge when ready

should have a follow up issue to integrate with the regular ci scripts when possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Needs Discussion Requires discussion from core team before further action
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants