Groupby transform cleanups #27467
Merged
Groupby transform cleanups #27467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2019
ghost
marked this pull request as ready for review
WillAyd
requested changes
Jul 19, 2019
| def test_transform_invalid_name_raises(): | ||
| df = DataFrame(dict(a=[0, 1, 1, 2])) | ||
| g = df.groupby(["a", "b", "b", "c"]) | ||
| with pytest.raises(ValueError, match="not a valid function name"): |
There was a problem hiding this comment.
Can you parametrize these instead?
There was a problem hiding this comment.
I don't think that's needed. Parameterize with one case is not useful, and as a smoke test there doesn't need to be more than one. Also lots of similar tests in this file.
|
Can you write release notes for each of the user-facing changes? If you merge master we should have a 0.26.0.rst now. |
added 7 commits
July 19, 2019 18:08
…leanups1 * origin/master: DOC: Fix typos in docstrings for functions referring. (#27474)
ghost
mentioned this pull request
jreback
requested changes
Jul 21, 2019
|
this also needs a whatsnew note. I am not so concerned about the invalid case (e.g. .transform('foo')), but something that looked legitimate and maybe even did something, though it may have been wrong, is now raising |
added 3 commits
July 21, 2019 09:46
added 12 commits
July 21, 2019 23:02
jreback
requested changes
Jul 24, 2019
added 4 commits
July 24, 2019 11:10
jreback
approved these changes
Jul 25, 2019
added 2 commits
July 25, 2019 13:16
…leanups1 * origin/master: (33 commits) TYPING: add type hints to pandas\io\formats\printing.py (#27579) TYPING: Partial typing of Categorical (#27318) REF: collect indexing methods (#27588) API: Add entrypoint for plotting (#27488) REF: implement module for shared constructor functions (#27551) CLN: more assorted cleanups (#27555) CLN: pandas\io\formats\format.py (#27577) TYPING: some type hints for core.dtypes.common (#27564) DEPR: remove .ix from tests/indexing/multiindex/test_ix.py (#27565) DEPR: remove .ix from tests/indexing/test_partial.py (#27566) TST: add regression test for slicing IntervalIndex MI level with scalars (#27572) DEPR: remove .ix from tests/indexing/multiindex/test_setitem.py (#27574) BUG: display.precision of negative complex numbers (#27511) Removed ABCs from pandas._typing (#27424) DEPR: remove .ix from tests/indexing/test_indexing.py (#27535) BUG: fix+test quantile with empty DataFrame, closes #23925 (#27436) BUG: maybe_convert_objects mixed datetimes and timedeltas (#27438) more type hints for io/formats/format.py (#27512) CLN: simplify join take call (#27531) BUG: Allow ensure_index to coerce nan to NaT with numpy object array and tz Timestamp (#27556) ...
|
@jreback green |
|
thanks @pilkibun |
ghost
mentioned this pull request
2 tasks
|
👍 |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #27389 (several issues there)
closes #27486