CLN: pandas\io\formats\format.py #27577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Output-Formatting
simonjayhawkins
commented
Jul 24, 2019
| formatter = self.formatter or _get_format_timedelta64( | ||
| self.values, nat_rep=self.nat_rep, box=self.box | ||
| ) | ||
| fmt_values = np.array([formatter(x) for x in self.values]) | ||
| return fmt_values | ||
| return [formatter(x) for x in self.values] |
There was a problem hiding this comment.
this is the most relevant change here.
return type now consistent with parent class and other formatters.
mypy should have picked this up. but since we don't have numpy stubs, all numpy types resolve to Any
jreback
reviewed
Jul 24, 2019
| Timedelta64Formatter( | ||
| values=self, nat_rep=na_rep, justify="all" | ||
| ).get_result() | ||
| ) |
There was a problem hiding this comment.
use asarray or pass copy=False
There was a problem hiding this comment.
sure. was keeping the code as close to original as possible.
pandas/io/formats/format.py
Outdated
| else: | ||
| return _trim_zeros_float(values, na_rep) | ||
| result = _trim_zeros_float(values, na_rep) | ||
| return np.array(result, dtype="object") |
jreback
requested changes
Jul 25, 2019
jreback
approved these changes
Jul 25, 2019
|
thanks @simonjayhawkins |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #27512 (comment)