CLN: more assorted cleanups #27555
Merged
CLN: more assorted cleanups #27555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jul 24, 2019
jreback
requested changes
Jul 24, 2019
| @@ -35,7 +35,7 @@ | |||
| is_object_dtype, | |||
| is_scalar, | |||
| ) | |||
| from pandas.core.dtypes.missing import isna, notna | |||
| from pandas.core.dtypes.missing import _isna_ndarraylike, isna, notna | |||
There was a problem hiding this comment.
future, can you de-privatize this
|
Comments addressed |
jreback
approved these changes
Jul 25, 2019
|
thanks @jbrockmendel |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing with the theme of avoiding runtime imports