CLN: Deduplicate show_versions #26816

TomAugspurger · 2019-06-12T19:00:35Z

The old version had special cases for numpy, scipy, and pytz. All those now provide a standard __version__. xlrd and xlwt are the only special ones now (__version__)

I messed up the minimum xlwt version in the last PR. I copied openpyxl's rather than xlwt's. That's now fixed.

I prettied up the output format a bit, to align the version numbers. Hope that 's OK.

INSTALLED VERSIONS
------------------
commit           : cbc6edf8bfad33c8bc698a3d035b593d921b0112
python           : 3.7.3.final.0
python-bits      : 64
OS               : Darwin
OS-release       : 18.6.0
machine          : x86_64
processor        : i386
byteorder        : little
LC_ALL           : None
LANG             : en_US.UTF-8
LOCALE           : en_US.UTF-8

pandas           : 0.25.0.dev0+729.gcbc6edf8b
pytest           : 4.6.2
pip              : 19.1.1
setuptools       : 41.0.1
Cython           : 0.29.10
numpy            : 1.17.0.dev0+5b06588
scipy            : 1.3.0
pyarrow          : 0.13.0
xarray           : 0.12.1
IPython          : 7.5.0
sphinx           : 1.8.5
patsy            : 0.5.1
dateutil         : 2.7.3
pytz             : 2018.5
blosc            : 1.5.1
bottleneck       : 1.2.1
tables           : 3.5.1
numexpr          : 2.6.8
feather          : 0.4.0
matplotlib       : 3.1.0
openpyxl         : 2.5.11
xlrd             : 1.1.0
xlwt             : 1.3.0
xlsxwriter       : 1.1.2
lxml.etree       : 4.2.5
bs4              : 4.7.1
html5lib         : 1.0.1
sqlalchemy       : 1.2.14
pymysql          : 0.9.2
psycopg2         : 2.7.6.1 (dt dec pq3 ext lo64)
jinja2           : 2.10.1
s3fs             : 0.1.6
fastparquet      : None
pandas_gbq       : 0.10.0
pandas_datareader: None
gcsfs            : 0.1.2

pandas/util/_print_versions.py

jreback · 2019-06-12T19:04:18Z

formatting looks nice!

codecov · 2019-06-12T19:29:14Z

Codecov Report

Merging #26816 into master will decrease coverage by <.01%.
The diff coverage is 27.77%.

@@            Coverage Diff             @@
##           master   #26816      +/-   ##
==========================================
- Coverage   91.87%   91.86%   -0.01%     
==========================================
  Files         180      180              
  Lines       50746    50748       +2     
==========================================
- Hits        46623    46622       -1     
- Misses       4123     4126       +3

Flag	Coverage Δ
#multiple	`90.46% <27.77%> (ø)`	⬆️
#single	`41.12% <27.77%> (-0.07%)`	⬇️

Impacted Files	Coverage Δ
pandas/compat/_optional.py	`100% <ø> (ø)`	⬆️
pandas/util/_test_decorators.py	`93.84% <100%> (+0.19%)`	⬆️
pandas/io/pytables.py	`90.29% <100%> (ø)`	⬆️
pandas/util/_print_versions.py	`15.71% <7.14%> (ø)`	⬆️
pandas/io/gbq.py	`88.88% <0%> (-11.12%)`	⬇️
pandas/core/frame.py	`96.89% <0%> (-0.12%)`	⬇️
pandas/util/testing.py	`90.94% <0%> (+0.1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd65e9...e384c40. Read the comment docs.

TomAugspurger · 2019-06-12T19:34:23Z

Got a bit carried away here, sorry.

Fixed xlwt version in the docs / VERSIONS
Updated pytables to use the new way, added to docs / VERSIONS
Added a test decorator for skipping if a library is installed
Deduplicate show_versions (the intent of this PR).

updated output:


INSTALLED VERSIONS
------------------
commit           : a8e0c2dff540ceada75fec07c6ccd4e6f0e79039
python           : 3.7.3.final.0
python-bits      : 64
OS               : Darwin
OS-release       : 18.6.0
machine          : x86_64
processor        : i386
byteorder        : little
LC_ALL           : None
LANG             : en_US.UTF-8
LOCALE           : en_US.UTF-8

pandas           : 0.25.0.dev0+730.ga8e0c2dff.dirty
numpy            : 1.17.0.dev0+5b06588
pytz             : 2018.5
dateutil         : 2.7.3
pip              : 19.1.1
setuptools       : 41.0.1
Cython           : 0.29.10
pytest           : 4.6.2
hypothesis       : 3.59.1
sphinx           : 1.8.5
blosc            : 1.5.1
feather          : 0.4.0
xlsxwriter       : 1.1.2
lxml.etree       : 4.2.5
html5lib         : 1.0.1
pymysql          : 0.9.2
psycopg2         : 2.7.6.1 (dt dec pq3 ext lo64)
jinja2           : 2.10.1
IPython          : 7.5.0
pandas_datareader: None
bs4              : 4.7.1
bottleneck       : 1.2.1
fastparquet      : None
gcsfs            : 0.1.2
matplotlib       : 3.1.0
numexpr          : 2.6.8
openpyxl         : 2.5.11
pandas_gbq       : 0.10.0
pyarrow          : 0.13.0
tables           : 3.5.2
s3fs             : 0.1.6
scipy            : 1.3.0
sqlalchemy       : 1.2.14
xarray           : 0.12.1
xlrd             : 1.1.0
xlwt             : 1.3.0

jreback · 2019-06-12T19:51:27Z

pandas/util/_test_decorators.py

@@ -140,6 +140,17 @@ def skip_if_no(
    )


+def skip_if_installed(


are u using this?

https://github.com/pandas-dev/pandas/pull/26816/files#diff-56c44e2fe6ac59a333e18f097db07524R57.

We should probably have a basic test like this for all our optional deps. Thoughts?

It can't go in test_pytables.py since that does an importorskip at the top of the file.

Alternatively, we could try monkeypatching / mocking the module, and never skipping these tests, but I've never had luck working around Python's import caching.

not sure i understand? we already test all of the optional deps but using them
are you suggesting something else?

are you suggesting something else?

Yeah, testing when that aren't present.

simonjayhawkins · 2019-06-12T20:01:43Z

pandas/tests/test_optional_dependency.py

@@ -50,3 +52,11 @@ def test_no_version_raises():

    with pytest.raises(ImportError, match="Can't determine .* fakemodule"):
        import_optional_dependency(name)
+
+
+@td.skip_if_installed("tables")


in the interest of better coverage, would it not be better to monkeypatch builtins.__import__ as was done in #26685 for tests like this rather than skip?

pandas/compat/_optional.py

jreback · 2019-06-13T18:37:20Z

lgtm. merge on green.

TomAugspurger · 2019-06-17T14:46:58Z

Apologies for the force push.

I've given up on my missing_dependency fixture. Split that off to #26902.

jreback

IIRC this had a lot more changes (meaning this actually did the de-duplication of show_versions)

jreback · 2019-06-19T00:49:36Z

pandas/tests/test_optional_dependency.py

+
+@td.skip_if_installed("tables")
+def test_pytables_raises():
+    df = pd.DataFrame({"A": [1, 2]})


can you go ahead and create

pandas/tests/io/pytables/test_missing_deps.py and put this there (we need to split test_pytables anyhow)

TomAugspurger · 2019-06-20T19:02:04Z

IIRC this had a lot more changes (meaning this actually did the de-duplication of show_versions)

Sorry, that de-duplication is restored now.

jreback · 2019-06-21T01:48:48Z

thanks @TomAugspurger very nice!

jreback requested changes Jun 12, 2019

View reviewed changes

pandas/util/_print_versions.py Outdated Show resolved Hide resolved

pandas/util/_print_versions.py Show resolved Hide resolved

jreback added CI Continuous Integration Dependencies Required and optional dependencies labels Jun 12, 2019

jreback added this to the 0.25.0 milestone Jun 12, 2019

jreback reviewed Jun 12, 2019

View reviewed changes

simonjayhawkins reviewed Jun 12, 2019

View reviewed changes

gfyoung reviewed Jun 12, 2019

View reviewed changes

pandas/compat/_optional.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

jreback approved these changes Jun 13, 2019

View reviewed changes

TomAugspurger force-pushed the 26814-optional-fu branch from 7d85c1b to da17f0d Compare June 13, 2019 18:58

update

aad77d6

TomAugspurger force-pushed the 26814-optional-fu branch from 09adcb7 to aad77d6 Compare June 17, 2019 14:42

This was referenced Jun 17, 2019

Debug CI #26903

Closed

debug CI #26904

Closed

jreback requested changes Jun 19, 2019

View reviewed changes

TomAugspurger added 3 commits June 20, 2019 08:38

restore cleanup

f988304

Merge remote-tracking branch 'upstream/master' into 26814-optional-fu

3db7492

move test

e384c40

jreback approved these changes Jun 21, 2019

View reviewed changes

jreback merged commit 7f8dd72 into pandas-dev:master Jun 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLN: Deduplicate show_versions #26816

CLN: Deduplicate show_versions #26816

TomAugspurger commented Jun 12, 2019 •

edited

Loading

jreback commented Jun 12, 2019

codecov bot commented Jun 12, 2019 •

edited

Loading

TomAugspurger commented Jun 12, 2019

jreback Jun 12, 2019

TomAugspurger Jun 12, 2019

TomAugspurger Jun 12, 2019 •

edited

Loading

jreback Jun 12, 2019 •

edited

Loading

TomAugspurger Jun 13, 2019

simonjayhawkins Jun 12, 2019

This comment has been minimized.

jreback commented Jun 13, 2019

TomAugspurger commented Jun 17, 2019

jreback left a comment

jreback Jun 19, 2019

TomAugspurger commented Jun 20, 2019

jreback commented Jun 21, 2019

CLN: Deduplicate show_versions #26816

CLN: Deduplicate show_versions #26816

Conversation

TomAugspurger commented Jun 12, 2019 • edited Loading

jreback commented Jun 12, 2019

codecov bot commented Jun 12, 2019 • edited Loading

Codecov Report

TomAugspurger commented Jun 12, 2019

jreback Jun 12, 2019

Choose a reason for hiding this comment

TomAugspurger Jun 12, 2019

Choose a reason for hiding this comment

TomAugspurger Jun 12, 2019 • edited Loading

Choose a reason for hiding this comment

jreback Jun 12, 2019 • edited Loading

Choose a reason for hiding this comment

TomAugspurger Jun 13, 2019

Choose a reason for hiding this comment

simonjayhawkins Jun 12, 2019

Choose a reason for hiding this comment

This comment has been minimized.

jreback commented Jun 13, 2019

TomAugspurger commented Jun 17, 2019

jreback left a comment

Choose a reason for hiding this comment

jreback Jun 19, 2019

Choose a reason for hiding this comment

TomAugspurger commented Jun 20, 2019

jreback commented Jun 21, 2019

TomAugspurger commented Jun 12, 2019 •

edited

Loading

codecov bot commented Jun 12, 2019 •

edited

Loading

TomAugspurger Jun 12, 2019 •

edited

Loading

jreback Jun 12, 2019 •

edited

Loading