ERR: include original error message for missing required dependencies #26685
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26685 +/- ##
===========================================
- Coverage 91.87% 41.76% -50.12%
===========================================
Files 174 174
Lines 50661 50661
===========================================
- Hits 46547 21157 -25390
- Misses 4114 29504 +25390
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26685 +/- ##
==========================================
- Coverage 91.72% 91.71% -0.01%
==========================================
Files 178 178
Lines 50779 50779
==========================================
- Hits 46578 46574 -4
- Misses 4201 4205 +4
Continue to review full report at Codecov.
|
|
Some errors in the CI, can you have a look? Let us know if you have questions. |
|
Hello @DanielFEvans! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-06-11 07:37:36 UTC |
jorisvandenbossche
changed the title
|
|
||
| if missing_dependencies: | ||
| raise ImportError( | ||
| "Missing required dependencies {0}".format(missing_dependencies)) | ||
| raise ImportError("Unable to import required dependencies:\n" + "\n".join(missing_dependencies)) |
There was a problem hiding this comment.
can you do this like
raise ImportError("Unable to import required dependencies:\n"
"\n".join(missing_dependencies))
since inside the parens you don't need the +
There was a problem hiding this comment.
That gives a different output - the current one joins the dependencies with \n:
Unable to import required dependencies:
a
b
c
Whereas without the "+" it joins them with the entire error message and two newlines:
aUnable to import required dependencies:
bUnable to import required dependencies:
c
|
@jreback - All green and good to go. |
|
looks good, can you merge master and ping on green. |
|
Second try ;) Thanks @DanielFEvans ! |
closes #23868
Resubmit of PR #26665, which was merged in a bit too eagerly!
Change to test hopefully avoids recursion, although like others, it doesn't reproduce locally for me.