-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ERR: include original error message for missing required dependencies #26685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 14 commits into
pandas-dev:master
from
DanielFEvans:issue_23868_import_errors
Jun 11, 2019
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c4bbc69
Modify error message for missing dependencies to report original erro…
DanielFEvans 70da233
Update whatsnew
DanielFEvans ab47d99
Fix for recursion in test
DanielFEvans 9556fca
Remove duplicate test patching
DanielFEvans 6eecf8b
Try re-reloading Pandas to ensure good state after test
DanielFEvans 7e09928
Alter definitions of temp variables in __init__ so they can be explic…
DanielFEvans fa85025
Use monkeypatch, not unittest
DanielFEvans 081327f
Changes to satisfy mypy
DanielFEvans 0e3038f
Move import test to test_downstream
DanielFEvans c07f751
Linting
DanielFEvans 6216ebf
Simplify missing dependency error formatting
DanielFEvans 3b00019
Correct error message formatting, minor change to changelog wording
DanielFEvans 0fff1fb
Add issue number to new test
DanielFEvans 014275a
Merge branch 'master' into issue_23868_import_errors
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you do this like
since inside the parens you don't need the +
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That gives a different output - the current one joins the dependencies with
\n
:Whereas without the "+" it joins them with the entire error message and two newlines: