Skip to content

Clean up code duplication in _optional and _print_versions #26814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Jun 12, 2019 · 1 comment · Fixed by #26816
Closed

Clean up code duplication in _optional and _print_versions #26814

WillAyd opened this issue Jun 12, 2019 · 1 comment · Fixed by #26816
Labels
Clean
Milestone
0.25.0

Comments

@WillAyd
Copy link
Member

WillAyd commented Jun 12, 2019

ref this comment #26802 (comment) we currently duplicate code in managing versions between the pandas.compat._optional and pandas.util._print_versions modules which we should align
@WillAyd WillAyd added the Clean label Jun 12, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone Jun 12, 2019
@WillAyd WillAyd mentioned this issue Jun 12, 2019
Merged
@TomAugspurger
Copy link
Contributor

Taking a look now.

@TomAugspurger TomAugspurger mentioned this issue Jun 12, 2019
Merged
@jreback jreback modified the milestones: Contributions Welcome, 0.25.0 Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

CLN: Deduplicate show_versions TomAugspurger/pandas
3 participants
@WillAyd @jreback @TomAugspurger