Skip to content

Remove Deprecated Azure CI Step #26384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2019
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented May 14, 2019

Found this while investigating #26345 may or may not be related but figured worth a separate PR in either case

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #26384 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26384      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.01%     
==========================================
  Files         174      174              
  Lines       50704    50704              
==========================================
- Hits        46488    46484       -4     
- Misses       4216     4220       +4
Flag Coverage Δ
#multiple 90.18% <ø> (ø) ⬆️
#single 41.18% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 304d8d4...870c3a5. Read the comment docs.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #26384 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26384      +/-   ##
==========================================
- Coverage   91.69%   91.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       50749    50743       -6     
==========================================
- Hits        46534    46524      -10     
- Misses       4215     4219       +4
Flag Coverage Δ
#multiple 90.19% <ø> (-0.01%) ⬇️
#single 41.19% <ø> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/core/groupby/generic.py 88.93% <0%> (-0.08%) ⬇️
pandas/core/groupby/groupby.py 97.23% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d15b2...9757973. Read the comment docs.

@datapythonista
Copy link
Member

@WillAyd looks like this step is required to install conda, right?

@WillAyd
Copy link
Member Author

WillAyd commented May 14, 2019

@datapythonista not entirely sure. The build logs show this task and deprecated and it appears to be documented as such on the Azure side:

https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/package/conda-environment?view=azure-devops#yaml-snippet

I think the preference is to use a task that just exposes conda via the system path:

https://docs.microsoft.com/en-us/azure/devops/pipelines/languages/anaconda?view=azure-devops&tabs=ubuntu-16-04#add-conda-to-your-system-path

@datapythonista
Copy link
Member

That sounds good to me. I saw that the CI was failing because of deleting the step, but if we can just set an environment variable that sounds better.

@WillAyd
Copy link
Member Author

WillAyd commented May 15, 2019

FWIW here's the issue on the Azure side of things:

microsoft/azure-pipelines-tasks#9573

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice clean up

logs mention about updating conda (i.e. conda update -n base -c defaults conda), may be we could add that, but in any case, happy with the PR

@jreback jreback added CI Continuous Integration Windows Windows OS labels May 15, 2019
@jreback jreback added this to the 0.25.0 milestone May 15, 2019
@jreback jreback merged commit 3ee85e1 into pandas-dev:master May 15, 2019
@jreback
Copy link
Contributor

jreback commented May 15, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the remove-depr-ci-step branch May 15, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Windows Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants