-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Remove Deprecated Azure CI Step #26384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26384 +/- ##
==========================================
- Coverage 91.68% 91.67% -0.01%
==========================================
Files 174 174
Lines 50704 50704
==========================================
- Hits 46488 46484 -4
- Misses 4216 4220 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26384 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 174 174
Lines 50749 50743 -6
==========================================
- Hits 46534 46524 -10
- Misses 4215 4219 +4
Continue to review full report at Codecov.
|
@WillAyd looks like this step is required to install conda, right? |
@datapythonista not entirely sure. The build logs show this task and deprecated and it appears to be documented as such on the Azure side: I think the preference is to use a task that just exposes conda via the system path: |
That sounds good to me. I saw that the CI was failing because of deleting the step, but if we can just set an environment variable that sounds better. |
FWIW here's the issue on the Azure side of things: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice clean up
logs mention about updating conda (i.e. conda update -n base -c defaults conda
), may be we could add that, but in any case, happy with the PR
thanks @WillAyd |
Found this while investigating #26345 may or may not be related but figured worth a separate PR in either case