Skip to content

Prefixed batch script commands with call #26383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented May 14, 2019

maybe fixes #26345

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #26383 into master will decrease coverage by 50.5%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26383       +/-   ##
===========================================
- Coverage   91.68%   41.18%   -50.51%     
===========================================
  Files         174      174               
  Lines       50704    50704               
===========================================
- Hits        46488    20880    -25608     
- Misses       4216    29824    +25608
Flag Coverage Δ
#multiple ?
#single 41.18% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.37%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.1%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
pandas/io/s3.py 0% <0%> (-89.48%) ⬇️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 304d8d4...34071f5. Read the comment docs.

@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #26383 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26383      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.01%     
==========================================
  Files         174      174              
  Lines       50704    50704              
==========================================
- Hits        46488    46484       -4     
- Misses       4216     4220       +4
Flag Coverage Δ
#multiple 90.18% <ø> (ø) ⬆️
#single 41.18% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 304d8d4...2da56d8. Read the comment docs.

@gfyoung
Copy link
Member

gfyoung commented May 14, 2019

@WillAyd : In light of #26345 (comment), can you try updating conda itself before doing the environment creation and see if that helps push your current changes to all green?

@WillAyd
Copy link
Member Author

WillAyd commented May 14, 2019

Good idea just pushed that through

@WillAyd
Copy link
Member Author

WillAyd commented May 14, 2019

Manually stopped the build but looks like that did get us past the issue

@WillAyd
Copy link
Member Author

WillAyd commented May 14, 2019

I'm not overly familiar with the CI here but perhaps related is also the fact that we have a deprecated task in our build that prevents Conda from being updated:

- task: CondaEnvironment@1

I'm going to push a separate PR for that; if it fixes this just by doing that great but may be worth removing given the deprecation in the logs regardless:

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=11409&view=logs&jobId=76104ccd-8dcc-5006-a17c-28bcdd709542&taskId=54201e92-6f3a-5f33-d5a0-ee2a32fc9e73&lineStart=4&lineEnd=5&colStart=1&colEnd=1

@WillAyd
Copy link
Member Author

WillAyd commented May 15, 2019

Closing as I don't think this is the right solution. Per comment by @datapythonista after refactoring Azure CI a Conda update is actually suggested:

#26384 (review)

So I'll push a separate PR which does that later and adds gcsfs back in

@WillAyd WillAyd closed this May 15, 2019
@WillAyd WillAyd deleted the ci-fix branch January 16, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 3.7 CI Failures
2 participants