Added conda update step and re-added gcsfs #26413
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26413 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 174 174
Lines 50739 50739
==========================================
- Hits 46524 46520 -4
- Misses 4215 4219 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26413 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 174 174
Lines 50739 50739
==========================================
- Hits 46524 46520 -4
- Misses 4215 4219 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Windows 37 was the problematic one right? I've verified that it's picked up gcsfs correctly.
Feel free to ignore my inline comment and just merge. I have a couple other changes I'd like to make (like including a conda env list before the test). I can do that later.
ci/azure/windows.yml
Outdated
| @@ -19,6 +19,8 @@ jobs: | |||
| steps: | |||
| - powershell: Write-Host "##vso[task.prependpath]$env:CONDA\Scripts" | |||
| displayName: Add conda to PATH | |||
| - script: conda update -n base conda | |||
There was a problem hiding this comment.
nitpick: it's nice to have -q here (and in the conda env create below) so that we don't have long logs just showing the download progress.
|
Good ideas and I think make sense to do here; just pushed a new commit with those changes |
|
So the conda version alone was responsible? |
|
I don’t think it was Conda alone but the issue is described in conda/conda#7776 if you want to read through it |
|
pls wait in merges this did not revert the original commit |
Isn't the rule a +1 from another dev?
I don't see anything leftover from #26352. Can you clarify? |
|
Ahh, looking at the wrong repo. I'll do a followup removing the extra gcsfs install. |
|
#26384 The setup script was removed entirely in |
|
it’s not about the +1 just more eyes |
git diff upstream/master -u -- "*.py" | flake8 --diff