Skip to content

CLN: remove compat.add_metaclass #26165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2019

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Apr 20, 2019

This removes the compat.add_metaclass function from the code base and replaces it with a metaclass parameter in class instation.

I don't understand why ExcelWriter needs to use a abc.ABCMeta metaclass, as the class is being used directly in the code base and I thought abstract classes couldn't be instantiated, but needed subclassing. I've kept abc.ABCMeta metaclass in ExcelWriter, but would appreciate advice.

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #26165 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26165      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52377    52365      -12     
==========================================
- Hits        48180    48165      -15     
- Misses       4197     4200       +3
Flag Coverage Δ
#multiple 90.53% <100%> (-0.01%) ⬇️
#single 40.7% <100%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 92.85% <ø> (+0.7%) ⬆️
pandas/io/excel/_base.py 92.78% <100%> (-0.04%) ⬇️
pandas/tseries/holiday.py 93.1% <100%> (-0.07%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc86509...6932c6e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #26165 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26165      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52377    52365      -12     
==========================================
- Hits        48180    48165      -15     
- Misses       4197     4200       +3
Flag Coverage Δ
#multiple 90.53% <100%> (-0.01%) ⬇️
#single 40.7% <100%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 92.85% <ø> (+0.7%) ⬆️
pandas/io/excel/_base.py 92.78% <100%> (-0.04%) ⬇️
pandas/tseries/holiday.py 93.1% <100%> (-0.07%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc86509...6932c6e. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Apr 21, 2019
@jreback jreback merged commit 150eddf into pandas-dev:master Apr 21, 2019
@topper-123 topper-123 deleted the remove_compat.add_metaclass branch April 21, 2019 16:31
ryanreh99 added a commit to ryanreh99/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants