CLN: remove compat.add_metaclass #26165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
compat.add_metaclass
function from the code base and replaces it with a metaclass parameter in class instation.I don't understand why
ExcelWriter
needs to use a abc.ABCMeta metaclass, as the class is being used directly in the code base and I thought abstract classes couldn't be instantiated, but needed subclassing. I've kept abc.ABCMeta metaclass inExcelWriter
, but would appreciate advice.