CLN: remove abc.abstractproperty from code base #26166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26166 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 175 175
Lines 52377 52379 +2
==========================================
- Hits 48180 48178 -2
- Misses 4197 4201 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26166 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 175 175
Lines 52377 52379 +2
==========================================
- Hits 48180 48178 -2
- Misses 4197 4201 +4
Continue to review full report at Codecov.
|
|
thanks @topper-123 |
ryanreh99
pushed a commit
to ryanreh99/pandas
that referenced
this pull request
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing #26165 I discovered some uses of
abc.abstractpropertyin the codebase. This propery was deprecated in Python 3.3 and superseeded by usingabc.abstractmethodandpropertytogether instead (see python abc.abstractproperty docs). I've therefore removed the uses ofabc.abstractpropertyfrom the code base.