Skip to content

CLN: remove __metaclass__ from code base #26178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

topper-123
Copy link
Contributor

Removes uses of __metaclass__ from the code base. After #26165 there was actually only one left.

@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #26178 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26178      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52371    52370       -1     
==========================================
- Hits        48175    48170       -5     
- Misses       4196     4200       +4
Flag Coverage Δ
#multiple 90.53% <100%> (-0.01%) ⬇️
#single 40.71% <100%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/computation/engines.py 88.33% <100%> (-0.2%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947bd76...fa898b0. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Apr 21, 2019
@topper-123 topper-123 force-pushed the remove___metaclass__ branch from 81011ba to fa898b0 Compare April 22, 2019 06:08
@topper-123 topper-123 changed the title CLN: remove __metaclass__ CLN: remove __metaclass__ from code base Apr 22, 2019
@WillAyd WillAyd merged commit b9e46ad into pandas-dev:master Apr 23, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 23, 2019

Thanks @topper-123

@topper-123 topper-123 deleted the remove___metaclass__ branch May 5, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants