-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove compat.iterkeys #26081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: remove compat.iterkeys #26081
Conversation
18fd6db
to
3c3e58b
Compare
aa5bb4d
to
72000d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #26081 +/- ##
=========================================
Coverage ? 40.75%
=========================================
Files ? 175
Lines ? 52442
Branches ? 0
=========================================
Hits ? 21372
Misses ? 31070
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26081 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.01%
==========================================
Files 175 175
Lines 52427 52425 -2
==========================================
- Hits 48208 48203 -5
- Misses 4219 4222 +3
Continue to review full report at Codecov.
|
Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-04-15 08:20:54 UTC |
72000d0
to
57eaccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure related to #26069
Thanks @mroeschke , I was not certain if the error was something I wasnt catching locally. |
@topper-123 : If you can address the merge conflicts that stemmed from merging your other PR, this should be good to go. |
c585349
to
48c6175
Compare
Rebased. |
thanks @pep8speaks |
* CLN: remove compat.iterkeys * minor clean-up
Removes
compat.iterkeys
.