Skip to content

CLN: remove compat.iterkeys #26081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

topper-123
Copy link
Contributor

Removes compat.iterkeys.

@topper-123 topper-123 force-pushed the clean_compat.iterkeys branch from 18fd6db to 3c3e58b Compare April 14, 2019 10:04
@topper-123 topper-123 marked this pull request as ready for review April 14, 2019 10:57
@topper-123 topper-123 force-pushed the clean_compat.iterkeys branch 2 times, most recently from aa5bb4d to 72000d0 Compare April 14, 2019 11:26
@codecov
Copy link

codecov bot commented Apr 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@190a69e). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26081   +/-   ##
=========================================
  Coverage          ?   40.75%           
=========================================
  Files             ?      175           
  Lines             ?    52442           
  Branches          ?        0           
=========================================
  Hits              ?    21372           
  Misses            ?    31070           
  Partials          ?        0
Flag Coverage Δ
#single 40.75% <0%> (?)
Impacted Files Coverage Δ
pandas/compat/__init__.py 82.75% <ø> (ø)
pandas/core/base.py 33.85% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190a69e...72000d0. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 14, 2019

Codecov Report

Merging #26081 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26081      +/-   ##
==========================================
- Coverage   91.95%   91.94%   -0.01%     
==========================================
  Files         175      175              
  Lines       52427    52425       -2     
==========================================
- Hits        48208    48203       -5     
- Misses       4219     4222       +3
Flag Coverage Δ
#multiple 90.5% <100%> (-0.01%) ⬇️
#single 40.72% <0%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 92.72% <ø> (-0.26%) ⬇️
pandas/core/base.py 97.99% <100%> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.71% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c9e2f...48c6175. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Apr 14, 2019

Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-15 08:20:54 UTC

@topper-123 topper-123 force-pushed the clean_compat.iterkeys branch from 72000d0 to 57eaccd Compare April 14, 2019 11:31
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure related to #26069

@topper-123
Copy link
Contributor Author

Thanks @mroeschke , I was not certain if the error was something I wasnt catching locally.

@gfyoung gfyoung added this to the 0.25.0 milestone Apr 15, 2019
@gfyoung
Copy link
Member

gfyoung commented Apr 15, 2019

@topper-123 : If you can address the merge conflicts that stemmed from merging your other PR, this should be good to go.

@topper-123 topper-123 force-pushed the clean_compat.iterkeys branch from c585349 to 48c6175 Compare April 15, 2019 08:20
@topper-123
Copy link
Contributor Author

Rebased.

@jreback jreback merged commit ecd4938 into pandas-dev:master Apr 15, 2019
@jreback
Copy link
Contributor

jreback commented Apr 15, 2019

thanks @pep8speaks

@topper-123 topper-123 mentioned this pull request Apr 15, 2019
1 task
@topper-123 topper-123 deleted the clean_compat.iterkeys branch April 15, 2019 22:22
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
* CLN: remove compat.iterkeys

* minor clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants