Skip to content

CLN: remove compat.itervalues #26099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

topper-123
Copy link
Contributor

Removes compat.itervalues.

@topper-123 topper-123 marked this pull request as ready for review April 15, 2019 12:52
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #26099 into master will decrease coverage by 51.22%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26099       +/-   ##
===========================================
- Coverage   91.96%   40.73%   -51.23%     
===========================================
  Files         175      175               
  Lines       52412    52406        -6     
===========================================
- Hits        48199    21346    -26853     
- Misses       4213    31060    +26847
Flag Coverage Δ
#multiple ?
#single 40.73% <37.5%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 81.13% <ø> (-11.6%) ⬇️
pandas/core/dtypes/concat.py 51.96% <ø> (-44.63%) ⬇️
pandas/core/groupby/generic.py 13.3% <0%> (-73.79%) ⬇️
pandas/core/base.py 33.93% <0%> (-64.28%) ⬇️
pandas/core/panel.py 16.21% <0%> (-19.32%) ⬇️
pandas/io/parsers.py 25.86% <100%> (-69.99%) ⬇️
pandas/core/nanops.py 31.39% <100%> (-62.45%) ⬇️
pandas/io/json/normalize.py 8.16% <50%> (-88.78%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3bf2d...1168f8f. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #26099 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26099      +/-   ##
==========================================
- Coverage   91.96%   91.95%   -0.01%     
==========================================
  Files         175      175              
  Lines       52412    52405       -7     
==========================================
- Hits        48200    48189      -11     
- Misses       4212     4216       +4
Flag Coverage Δ
#multiple 90.51% <87.5%> (-0.01%) ⬇️
#single 40.72% <37.5%> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 92.45% <ø> (-0.28%) ⬇️
pandas/core/dtypes/concat.py 96.56% <ø> (-0.02%) ⬇️
pandas/core/panel.py 35.43% <0%> (-0.1%) ⬇️
pandas/io/json/normalize.py 96.93% <100%> (ø) ⬆️
pandas/core/groupby/generic.py 87.07% <100%> (-0.02%) ⬇️
pandas/core/base.py 98.2% <100%> (-0.01%) ⬇️
pandas/io/parsers.py 95.84% <100%> (ø) ⬆️
pandas/core/nanops.py 93.82% <100%> (-0.02%) ⬇️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3bf2d...1168f8f. Read the comment docs.

@topper-123
Copy link
Contributor Author

topper-123 commented Apr 15, 2019

The failure is the one mentioned by @mroeschke here: #26081 (review). It's unrelated to this PR.

@jschendel jschendel added this to the 0.25.0 milestone Apr 15, 2019
Copy link
Member

@jschendel jschendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; restarted the build with unrelated failure

@mroeschke mroeschke merged commit b90f9db into pandas-dev:master Apr 15, 2019
@mroeschke
Copy link
Member

Thanks @topper-123!

@topper-123 topper-123 deleted the cln_itervalues branch April 15, 2019 22:22
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants