-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove compat.itervalues #26099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b2e9b42
to
4329b94
Compare
4329b94
to
1168f8f
Compare
Codecov Report
@@ Coverage Diff @@
## master #26099 +/- ##
===========================================
- Coverage 91.96% 40.73% -51.23%
===========================================
Files 175 175
Lines 52412 52406 -6
===========================================
- Hits 48199 21346 -26853
- Misses 4213 31060 +26847
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26099 +/- ##
==========================================
- Coverage 91.96% 91.95% -0.01%
==========================================
Files 175 175
Lines 52412 52405 -7
==========================================
- Hits 48200 48189 -11
- Misses 4212 4216 +4
Continue to review full report at Codecov.
|
The failure is the one mentioned by @mroeschke here: #26081 (review). It's unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; restarted the build with unrelated failure
Thanks @topper-123! |
Removes
compat.itervalues
.