Skip to content

CI: test_drop_duplicates_categorical_non_bool is flaky #26069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jschendel opened this issue Apr 12, 2019 · 1 comment
Closed

CI: test_drop_duplicates_categorical_non_bool is flaky #26069

jschendel opened this issue Apr 12, 2019 · 1 comment
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail

Comments

@jschendel
Copy link
Member

I've noticed recently that the xfailed part of the following test is occasionally xpassing, which is causing the test suite to fail due to being strict with xpass:

@pytest.mark.parametrize(
"dtype",
["int_", "uint", "float_", "unicode_", "timedelta64[h]",
pytest.param("datetime64[D]",
marks=pytest.mark.xfail(reason="GH#7996"))]
)
@pytest.mark.parametrize("is_ordered", [True, False])
def test_drop_duplicates_categorical_non_bool(self, dtype, is_ordered):

The quick fix is to update the xfail with strict=False but additional investigation into why this is occasionally passing would also be appreciated.

Examples of the xpass:

@jschendel jschendel added CI Continuous Integration Unreliable Test Unit tests that occasionally fail labels Apr 12, 2019
@jschendel jschendel added this to the Contributions Welcome milestone Apr 12, 2019
jreback added a commit to jreback/pandas that referenced this issue Apr 20, 2019
yhaque1213 pushed a commit to yhaque1213/pandas that referenced this issue Apr 22, 2019
ryanreh99 pushed a commit to ryanreh99/pandas that referenced this issue Apr 22, 2019
@mroeschke
Copy link
Member

Looks like we no longer have an xfail on the parameter. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

No branches or pull requests

2 participants