Add test for rdivmod on EA array (GH23287) #24047

makbigc · 2018-12-02T13:34:22Z

closes TST: rdivmod on EA Arrays #23287
test added
passes git diff upstream/master -u -- "*.py" | flake8 --diff

pep8speaks · 2018-12-02T13:34:28Z

Hello @makbigc! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-16 11:45:24 UTC

jreback · 2018-12-02T17:57:12Z

pandas/tests/extension/base/ops.py

@@ -92,10 +93,18 @@ def test_divmod(self, data):
        self._check_divmod_op(s, divmod, 1, exc=self.divmod_exc)
        self._check_divmod_op(1, ops.rdivmod, s, exc=self.divmod_exc)

-    def test_divmod_series_array(self, data):
+    def test_divmod_series_array(self, data, ones):
+        #pytest.set_trace()


don't leave things like this as they break linting

codecov · 2018-12-05T14:20:10Z

Codecov Report

Merging #24047 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24047   +/-   ##
=======================================
  Coverage   42.46%   42.46%           
=======================================
  Files         161      161           
  Lines       51557    51557           
=======================================
  Hits        21892    21892           
  Misses      29665    29665

Flag	Coverage Δ
#single	`42.46% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45eb26...5104749. Read the comment docs.

codecov · 2018-12-05T14:20:11Z

Codecov Report

Merging #24047 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24047      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         172      172              
  Lines       52977    52977              
==========================================
- Hits        48343    48342       -1     
- Misses       4634     4635       +1

Flag	Coverage Δ
#multiple	`89.82% <ø> (ø)`	⬆️
#single	`41.74% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/util/testing.py	`88.98% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c0441...6d80b58. Read the comment docs.

pandas/tests/extension/decimal/test_decimal.py

jreback · 2018-12-25T18:15:57Z

can you merge master and rebase

pandas/tests/extension/decimal/test_decimal.py

jreback · 2018-12-25T23:59:11Z

pandas/tests/extension/test_period.py

@@ -125,6 +125,9 @@ def test_direct_arith_with_series_returns_not_implemented(self, data):
        result = data.__sub__(other)
        assert result is NotImplemented

+    def test_divmod_series_array(self):


this should work, no?

The arithmetic operation isn't implemented for period_array. other = data_for_ones * 2 run into an error. I change data_for_ones to data_for_twos, so the base test can run for more EA subclasses.

WillAyd · 2019-02-27T23:53:50Z

@makbigc can you merge master on this one?

jreback · 2019-03-03T03:16:04Z

pandas/tests/extension/test_categorical.py

@@ -210,6 +210,9 @@ def test_add_series_with_extension_array(self, data):
        with pytest.raises(TypeError, match="cannot perform"):
            ser + data

+    def test_divmod_series_array(self):
+        pass


can you add a comment (skipping because its NotImplemented)

jreback · 2019-03-03T03:16:46Z

@jbrockmendel can you have a look

jbrockmendel · 2019-03-03T17:04:16Z

Looks fine to me. I'm not particularly well-versed in this directory of the tests.

TomAugspurger

I think you should add a fixture to pandas/tests/extensions/conftest.py. The docstring should describe the expected semantics of the data_for_twos fixture.

jreback · 2019-03-10T16:10:45Z

this looks fine, can you merge master and get tests to pass.

jreback · 2019-03-20T00:05:21Z

thanks @makbigc

* origin/master: DOC: clean bug fix section in whatsnew (pandas-dev#25792) DOC: Fixed PeriodArray api ref (pandas-dev#25526) Move locale code out of tm, into _config (pandas-dev#25757) Unpin pycodestyle (pandas-dev#25789) Add test for rdivmod on EA array (GH23287) (pandas-dev#24047) ENH: Support datetime.timezone objects (pandas-dev#25065) Cython language level 3 (pandas-dev#24538) API: concat on sparse values (pandas-dev#25719) TST: assert_produces_warning works with filterwarnings (pandas-dev#25721) make core.config self-contained (pandas-dev#25613) CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721) TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) DOC: Fix typo in docstring of DataFrame.memory_usage (pandas-dev#25770) Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693) TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640) DOC: Improve the docsting of Series.iteritems (pandas-dev#24879) DOC: Fix function name. (pandas-dev#25751) Implementing iso_week_year support for to_datetime (pandas-dev#25541) DOC: clarify corr behaviour when using a callable (pandas-dev#25732) remove unnecessary check_output (pandas-dev#25755) # Conflicts: # doc/source/whatsnew/v0.25.0.rst

* upstream/master: (55 commits) PERF: Improve performance of StataReader (pandas-dev#25780) Speed up tokenizing of a row in csv and xstrtod parsing (pandas-dev#25784) BUG: Fix _binop for operators for serials which has more than one returns (divmod/rdivmod). (pandas-dev#25588) BUG-24971 copying blocks also considers ndim (pandas-dev#25521) CLN: Panel reference from documentation (pandas-dev#25649) ENH: Quoting column names containing spaces with backticks to use them in query and eval. (pandas-dev#24955) BUG: reading windows utf8 filenames in py3.6 (pandas-dev#25769) DOC: clean bug fix section in whatsnew (pandas-dev#25792) DOC: Fixed PeriodArray api ref (pandas-dev#25526) Move locale code out of tm, into _config (pandas-dev#25757) Unpin pycodestyle (pandas-dev#25789) Add test for rdivmod on EA array (GH23287) (pandas-dev#24047) ENH: Support datetime.timezone objects (pandas-dev#25065) Cython language level 3 (pandas-dev#24538) API: concat on sparse values (pandas-dev#25719) TST: assert_produces_warning works with filterwarnings (pandas-dev#25721) make core.config self-contained (pandas-dev#25613) CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721) TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) DOC: Fix typo in docstring of DataFrame.memory_usage (pandas-dev#25770) ...

jreback requested changes Dec 2, 2018

View reviewed changes

jreback added the ExtensionArray Extending pandas with custom dtypes or arrays. label Dec 2, 2018

jreback reviewed Dec 5, 2018

View reviewed changes

pandas/tests/extension/decimal/test_decimal.py Show resolved Hide resolved

jreback requested changes Dec 25, 2018

View reviewed changes

makbigc force-pushed the test-add-GH23287 branch from 5104749 to fbbbf90 Compare December 27, 2018 10:41

jreback added this to the 0.25.0 milestone Mar 3, 2019

jreback requested changes Mar 3, 2019

View reviewed changes

TomAugspurger reviewed Mar 5, 2019

View reviewed changes

makbigc force-pushed the test-add-GH23287 branch from fbbbf90 to a93eef9 Compare March 10, 2019 04:01

makbigc added 5 commits March 16, 2019 19:44

Add test for rdivmod on EA array (GH23287)

c26b200

Rename ones as data_for_ones

a4c8665

Change data_for_ones to data_for_twos

269661d

Amend after review

9fd8b08

Add test_divmod_series_array in test_datetime.py

6d80b58

makbigc force-pushed the test-add-GH23287 branch from a93eef9 to 6d80b58 Compare March 16, 2019 11:45

jreback approved these changes Mar 20, 2019

View reviewed changes

jreback merged commit a70eb0f into pandas-dev:master Mar 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for rdivmod on EA array (GH23287) #24047

Add test for rdivmod on EA array (GH23287) #24047

makbigc commented Dec 2, 2018

pep8speaks commented Dec 2, 2018 •

edited

Loading

jreback Dec 2, 2018

codecov bot commented Dec 5, 2018

codecov bot commented Dec 5, 2018 •

edited

Loading

jreback commented Dec 25, 2018

jreback Dec 25, 2018

makbigc Dec 27, 2018

WillAyd commented Feb 27, 2019

jreback Mar 3, 2019

jreback commented Mar 3, 2019

jbrockmendel commented Mar 3, 2019

TomAugspurger left a comment

jreback commented Mar 10, 2019

jreback commented Mar 20, 2019

Add test for rdivmod on EA array (GH23287) #24047

Add test for rdivmod on EA array (GH23287) #24047

Conversation

makbigc commented Dec 2, 2018

pep8speaks commented Dec 2, 2018 • edited Loading

Comment last updated at 2019-03-16 11:45:24 UTC

jreback Dec 2, 2018

Choose a reason for hiding this comment

codecov bot commented Dec 5, 2018

Codecov Report

codecov bot commented Dec 5, 2018 • edited Loading

Codecov Report

jreback commented Dec 25, 2018

jreback Dec 25, 2018

Choose a reason for hiding this comment

makbigc Dec 27, 2018

Choose a reason for hiding this comment

WillAyd commented Feb 27, 2019

jreback Mar 3, 2019

Choose a reason for hiding this comment

jreback commented Mar 3, 2019

jbrockmendel commented Mar 3, 2019

TomAugspurger left a comment

Choose a reason for hiding this comment

jreback commented Mar 10, 2019

jreback commented Mar 20, 2019

pep8speaks commented Dec 2, 2018 •

edited

Loading

codecov bot commented Dec 5, 2018 •

edited

Loading