Skip to content

TST: rdivmod on EA Arrays #23287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Oct 23, 2018 · 1 comment · Fixed by #24047
Closed

TST: rdivmod on EA Arrays #23287

jreback opened this issue Oct 23, 2018 · 1 comment · Fixed by #24047
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

xref #23271

I think we need to add a test case for rdivmod as its now defined on Series.

@jreback jreback added Testing pandas testing functions or related to the test suite ExtensionArray Extending pandas with custom dtypes or arrays. labels Oct 23, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 23, 2018
@jorisvandenbossche
Copy link
Member

There are at least already tests for Series with scalar (but not Series/Series or Series/array), it seems:

def test_divmod(self, data):
s = pd.Series(data)
self._check_divmod_op(s, divmod, 1, exc=self.divmod_exc)
self._check_divmod_op(1, ops.rdivmod, s, exc=self.divmod_exc)
def test_divmod_series_array(self, data):
s = pd.Series(data)
self._check_divmod_op(s, divmod, data)

@jreback jreback modified the milestones: 0.24.0, Contributions Welcome Nov 25, 2018
@jreback jreback modified the milestones: Contributions Welcome, 0.25.0 Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants