TST: Fixturize tests/frame/test_missing.py #25640
Conversation
h-vetinari
changed the title
Codecov Report
@@ Coverage Diff @@
## master #25640 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 173 173
Lines 52968 52968
=======================================
Hits 48339 48339
Misses 4629 4629
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25640 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 173 173
Lines 52961 52961
=======================================
Hits 48349 48349
Misses 4612 4612
Continue to review full report at Codecov.
|
WillAyd
added
Testing
pandas/tests/frame/test_missing.py
Outdated
| mf.loc[mf.index[5:20], 'foo'] = np.nan | ||
| mf.loc[mf.index[-10:], 'A'] = np.nan | ||
| result = float_string_frame.fillna(value=0) | ||
| result = float_string_frame.fillna(method='pad') # noqa |
There was a problem hiding this comment.
Rather than noqa can just remove assignment
There was a problem hiding this comment.
Well, unfortunately, this split (along fixtures) requested by @jreback is uncovering deficiencies in the existing test, in that both results are not tested for anything. Don't know what this should be...
There was a problem hiding this comment.
Sure entirely possible to have some mistakes in the existing tests. I'd suggest adding a TODO here to make a stronger assertion and opening a follow up issue.
For time being OK to remove lhs and noqa note; at the very least I suppose this tests that the method doesn't raise
|
lgtm ex @WillAyd comment |
pandas/tests/frame/test_missing.py
Outdated
| mf.loc[mf.index[5:20], 'foo'] = np.nan | ||
| mf.loc[mf.index[-10:], 'A'] = np.nan | ||
| result = float_string_frame.fillna(value=0) | ||
| result = float_string_frame.fillna(method='pad') # noqa |
There was a problem hiding this comment.
Well, unfortunately, this split (along fixtures) requested by @jreback is uncovering deficiencies in the existing test, in that both results are not tested for anything. Don't know what this should be...
|
Thanks @h-vetinari ! |
* origin/master: DOC: clean bug fix section in whatsnew (pandas-dev#25792) DOC: Fixed PeriodArray api ref (pandas-dev#25526) Move locale code out of tm, into _config (pandas-dev#25757) Unpin pycodestyle (pandas-dev#25789) Add test for rdivmod on EA array (GH23287) (pandas-dev#24047) ENH: Support datetime.timezone objects (pandas-dev#25065) Cython language level 3 (pandas-dev#24538) API: concat on sparse values (pandas-dev#25719) TST: assert_produces_warning works with filterwarnings (pandas-dev#25721) make core.config self-contained (pandas-dev#25613) CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721) TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) DOC: Fix typo in docstring of DataFrame.memory_usage (pandas-dev#25770) Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693) TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640) DOC: Improve the docsting of Series.iteritems (pandas-dev#24879) DOC: Fix function name. (pandas-dev#25751) Implementing iso_week_year support for to_datetime (pandas-dev#25541) DOC: clarify corr behaviour when using a callable (pandas-dev#25732) remove unnecessary check_output (pandas-dev#25755) # Conflicts: # doc/source/whatsnew/v0.25.0.rst
One more steps towards #22471.