-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
STYLE: Fixing and refactoring linting #22863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
datapythonista
merged 19 commits into
pandas-dev:master
from
datapythonista:lint_refactor
Oct 9, 2018
Merged
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1811954
Refactoring lint.sh, wrong path pandas/src corrected, and made more c…
datapythonista 6ace7ef
fixing linting errors in pxi.in files (linting was broken)
datapythonista a28a612
unifying the flake8 error codes that are being ignored
datapythonista af76f11
Restoring flake errors C406, C408 and C409
datapythonista 07ebcd0
Unpinning flake8, to see if linting works with the latest version
datapythonista 34e85f0
Synchronizing flake8 config in pep8speaks
datapythonista adcda47
Unifying all flake8 of .py files in one command, and moving excludes …
datapythonista c129197
Printing flake8 version, and moving doctests and check_import to lint.sh
datapythonista 803b217
Moving linting from py2.7 to py3.6
datapythonista 62a8813
Moving flake8/cpplint requirements to 3.6, as this is now where the l…
datapythonista 720f18c
Merge remote-tracking branch 'upstream/master' into lint_refactor
datapythonista cabe353
lint.sh renamed to code_checks.sh, and parameters now supported to ca…
datapythonista 9a76f58
Fixing linting script name in travis
datapythonista f4e17ad
Merging from master
datapythonista 56eca8f
merging from master
datapythonista 879157f
Merge remote-tracking branch 'upstream/master' into lint_refactor
datapythonista 0ec16fe
Adding documentation to the new linting script
datapythonista cd38de3
Fix linting error in the code, and added more information for when LI…
datapythonista 8738e80
Fixing formatting in the documentation
datapythonista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this seems like a good change to me! Quick question I recently actually enforced E741 in pep8speaks config, #22795. Hence this error will be flagged on any new PRs which is the behaviour we want? I was going to follow up remove any final instances of this in codebase. See #22122
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now is important to have consistency between the CI and pep8speaks, and among all the different files. I don't have a strong opinion about E741, or the errors discussed in #22122, in general I think the less exceptions we have, the better.