TST/CLN: clean up indexes/multi/test_unique_and_duplicates #21900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure appears unrelated. Can you push again so it re-runs? |
Codecov Report
@@ Coverage Diff @@
## master #21900 +/- ##
==========================================
+ Coverage 91.95% 91.96% +<.01%
==========================================
Files 166 166
Lines 50274 50323 +49
==========================================
+ Hits 46231 46281 +50
+ Misses 4043 4042 -1
Continue to review full report at Codecov.
|
|
@jbrockmendel All green :) |
jreback
requested changes
Jul 14, 2018
|
|
||
|
|
||
| def test_duplicate_level_names_access_raises(idx): | ||
| idx.names = ['foo', 'foo'] |
There was a problem hiding this comment.
is there an issue number asssociated?
There was a problem hiding this comment.
Don't know, just moving tests around
| from pandas.compat import range, u | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
should go in the conftest.py
jreback
added
Testing
jreback
approved these changes
Jul 16, 2018
|
thanks @h-vetinari |
4 tasks
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Jul 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #21645
duplicated, including a fixture for aMultiIndexwith duplicatestest_duplicates) into smaller chunkstest_unique_na) that was for anIndex(notMultiIndex), and exists verbatim intests/indexes/common.pytest_duplicate_level_names_access_raisesto its appropriate module