CLN: Address MulitIndex Test Follow Ups in Issue #21918 #21928
Conversation
| @@ -234,29 +234,32 @@ def test_from_arrays_empty(): | |||
| tm.assert_index_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_from_arrays_invalid_input(): | |||
| @pytest.mark.parametrize('invalid_array', [ | |||
| pytest.param(1), | |||
There was a problem hiding this comment.
you dont' need to use pytest.parma, just use tuples
jreback
added
Testing
|
also merged #21900 so will need to rebase |
removed test_operations.py fixed syntax for python 2.7 fix comments from commit
elmq0022
force-pushed
the
clean_test_multi
branch
from
d444188 to
a887988
Compare
Codecov Report
@@ Coverage Diff @@
## master #21928 +/- ##
==========================================
+ Coverage 91.96% 91.99% +0.03%
==========================================
Files 166 167 +1
Lines 50323 50578 +255
==========================================
+ Hits 46281 46531 +250
- Misses 4042 4047 +5
Continue to review full report at Codecov.
|
|
@jreback all green. |
| idx._bounds | ||
|
|
||
|
|
||
| def test_append(idx): |
There was a problem hiding this comment.
can you move things like append / insert (ops that are shape shifting) to a new file, maybe test_reshape.py
There was a problem hiding this comment.
@jreback would you put groupby into this category?
There was a problem hiding this comment.
you can leave groupby here
| idx.reorder_levels, [2, 1, 0]) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize('ordered', [True, False]) |
There was a problem hiding this comment.
we have an astype file (you just created)
| idx._bounds | ||
|
|
||
|
|
||
| def test_append(idx): |
There was a problem hiding this comment.
you can leave groupby here
|
@jreback all green. I made the additional edits and some further cleaning as well. Thanks! |
| assert tm.equalContents(result, answer) | ||
| answer = idx[[0, -1]] | ||
| result = first.symmetric_difference(second) | ||
| assert tm.equalContents(result, answer) | ||
|
|
||
| # GH 10149 | ||
| cases = [klass(second.values) |
There was a problem hiding this comment.
if you want to come back and parameterize things like this would be great (but future PR)
|
thanks @elmq0022 nice cleaning! |
git diff upstream/master -u -- "*.py" | flake8 --diffAddresses most of the issues. Left blowing away the old pickles for another issue which is still open.