BUG: Should not raises errors in .set_names and comparison methods for MultiIndex with nlevels == 1 (GH21149) #21182
Conversation
Updating to 0.23.0
Update 18 May
GH21149
|
@toobaz have made necessary updates for #21149 original issue with set_names is fixed Also, with the previous code snippet in |
|
Resolved the earlier conflict with |
KalyanGokhale
changed the title
|
Will check the test failure and resubmit after necessary edits |
| @@ -3291,3 +3291,37 @@ def test_duplicate_multiindex_labels(self): | |||
| with pytest.raises(ValueError): | |||
| ind.set_levels([['A', 'B', 'A', 'A', 'B'], [2, 1, 3, -2, 5]], | |||
| inplace=True) | |||
|
|
|||
| testdata = [ | |||
| (pd.MultiIndex.from_product([[0, 1], [1, 0]]), pd.Series(range(4)), 4), | |||
There was a problem hiding this comment.
don't create a variable here, just put it directly in the parametrize (see how to format it from other tests)
|
|
||
| @pytest.mark.parametrize("midx,idx,count", testdata) | ||
| def test_multiindex_compare(self, midx, idx, count): | ||
| # GH 21149 - change in 'def cmp_method()' |
There was a problem hiding this comment.
this is a non-sensical comment, be more descriptive.
| with tm.assert_raises_regex(TypeError, 'not supported'): | ||
| midx > idx | ||
|
|
||
| def test_multiindex_set_names(self): |
There was a problem hiding this comment.
put this near the other tests for set_names
| # GH 21149 - change in 'def cmp_method()' | ||
| expected = pd.Series([True]).repeat(count) | ||
| expected.reset_index(drop=True, inplace=True) | ||
| result = pd.Series(midx == midx) |
There was a problem hiding this comment.
not really clear what you are testing, this is way too dense. put blank lines and a comment in between cases.
git diff upstream/master -u -- "*.py" | flake8 --diff