BUG: Should not raise errors in .set_names for MultiIndex with nlevels == 1 (GH21149) #21196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating to 0.23.0
Update 18 May
24 May fork update
GH21149-2
4 tasks
KalyanGokhale
changed the title
KalyanGokhale
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21196 +/- ##
=========================================
Coverage ? 91.84%
=========================================
Files ? 153
Lines ? 49506
Branches ? 0
=========================================
Hits ? 45467
Misses ? 4039
Partials ? 0
Continue to review full report at Codecov.
|
jreback
requested changes
May 24, 2018
doc/source/whatsnew/v0.23.1.txt
Outdated
| @@ -78,7 +78,8 @@ Indexing | |||
|
|
|||
| - Bug in :meth:`Series.reset_index` where appropriate error was not raised with an invalid level name (:issue:`20925`) | |||
| - Bug in :func:`interval_range` when ``start``/``periods`` or ``end``/``periods`` are specified with float ``start`` or ``end`` (:issue:`21161`) | |||
| - | |||
| - Bug in :meth:`MultiIndex.set_names` where error raised for a MultiIndex with self.nlevels == 1 (:issue:`21149`) | |||
There was a problem hiding this comment.
just say nlevels == 1 (in double backticks)
There was a problem hiding this comment.
Thanks - done
pandas/tests/indexes/test_multi.py
Outdated
| @@ -165,6 +165,18 @@ def test_set_name_methods(self): | |||
| assert res is None | |||
| assert ind.names == new_names2 | |||
|
|
|||
| def test_multiindex_set_names(self): | |||
| # GH 21149 | |||
| '''Ensure that .set_names for MultiIndex with | |||
pandas/tests/indexes/test_multi.py
Outdated
| nlevels == 1 does not raise any errors | ||
| ''' | ||
| result = pd.MultiIndex.from_product([[0, 1]]) | ||
| result.set_names('first', level=0, inplace=True) |
There was a problem hiding this comment.
test both inplace=True and False with a parameterized test
jreback
approved these changes
May 29, 2018
|
thanks @KalyanGokhale certainly love for you to kill the nlevels==1 checks in the rest of the code base :> |
|
Thanks @jreback - will comb through the codes for other nlevels==1 instances and would work on it |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jun 8, 2018
…s == 1 (GH21149) (pandas-dev#21196) (cherry picked from commit a5259cc)
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffInitial PR #21182 is closed - and now split in 2 different PRs