-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Should not raises errors in .set_names and comparison methods for MultiIndex with nlevels == 1 (GH21149) #21182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d0c7ebc
143566a
dd60b4e
aaf7f39
5cc8187
4f5db97
670df99
85f5b9e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3291,3 +3291,37 @@ def test_duplicate_multiindex_labels(self): | |
with pytest.raises(ValueError): | ||
ind.set_levels([['A', 'B', 'A', 'A', 'B'], [2, 1, 3, -2, 5]], | ||
inplace=True) | ||
|
||
testdata = [ | ||
(pd.MultiIndex.from_product([[0, 1], [1, 0]]), pd.Series(range(4)), 4), | ||
(pd.MultiIndex.from_product([[0, 1]]), pd.Series(range(2)), 2), | ||
] | ||
|
||
@pytest.mark.parametrize("midx,idx,count", testdata) | ||
def test_multiindex_compare(self, midx, idx, count): | ||
# GH 21149 - change in 'def cmp_method()' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a non-sensical comment, be more descriptive. |
||
expected = pd.Series([True]).repeat(count) | ||
expected.reset_index(drop=True, inplace=True) | ||
result = pd.Series(midx == midx) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not really clear what you are testing, this is way too dense. put blank lines and a comment in between cases. |
||
tm.assert_series_equal(result, expected) | ||
result = (idx == idx) | ||
tm.assert_series_equal(result, expected) | ||
|
||
expected = pd.Series([False]).repeat(count) | ||
expected.reset_index(drop=True, inplace=True) | ||
result = pd.Series(midx > midx) | ||
tm.assert_series_equal(result, expected) | ||
result = pd.Series(midx == idx) | ||
tm.assert_series_equal(result, expected) | ||
|
||
with tm.assert_raises_regex(TypeError, 'not supported'): | ||
midx > idx | ||
|
||
def test_multiindex_set_names(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. put this near the other tests for set_names |
||
# GH 21149 - change in 'def set_names()' | ||
result = pd.MultiIndex.from_product([[0, 1]]) | ||
result.set_names('first', level=0, inplace=True) | ||
expected = pd.MultiIndex(levels=[[0, 1]], | ||
labels=[[0, 1]], | ||
names=['first']) | ||
tm.assert_index_equal(result, expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't create a variable here, just put it directly in the parametrize (see how to format it from other tests)