Skip to content

Replaced open with Context Mgrs in Parser Tests #21105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2018

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented May 17, 2018

Maybe closes #21102 and #19984, though if not should still work as a general cleanup

@alysivji
Copy link
Contributor

Just did a search and there are a surprising number of non-context manager opens in the codebase. Is there a cleanup effort around this? Fix as you see them?

@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #21105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21105   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         153      153           
  Lines       49497    49497           
=======================================
  Hits        45456    45456           
  Misses       4041     4041
Flag Coverage Δ
#multiple 90.23% <ø> (ø) ⬆️
#single 41.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d623ffd...e61612a. Read the comment docs.

@WillAyd
Copy link
Member Author

WillAyd commented May 17, 2018

@alysivji are those using IO buffers or file handles? If the former I don't think it's a necessity. The latter should definitely be cleaned up

@jreback jreback added Testing pandas testing functions or related to the test suite IO CSV read_csv, to_csv labels May 19, 2018
@jreback jreback added this to the 0.23.1 milestone May 19, 2018
@jreback jreback merged commit ed784a8 into pandas-dev:master May 19, 2018
@jreback
Copy link
Contributor

jreback commented May 19, 2018

thanks @WillAyd

if you can see if #21102 and #19984 are fixed would be great.

@WillAyd
Copy link
Member Author

WillAyd commented May 20, 2018

Is that validated by restarting the failed jobs associated with those?

@jreback
Copy link
Contributor

jreback commented May 20, 2018

oh those were just transient issues
u can restart older jobs but not much point as you generally need to rebase anyhow

@WillAyd
Copy link
Member Author

WillAyd commented May 20, 2018

OK yea figured that was the case. I'm reading this as "wait and see if this issue pops back up again" so doing nothing for now, but if I'm missing something let me know

@jreback
Copy link
Contributor

jreback commented May 20, 2018

yep - nothing to do now

@WillAyd WillAyd mentioned this pull request May 30, 2018
4 tasks
jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Jun 8, 2018
jorisvandenbossche pushed a commit that referenced this pull request Jun 9, 2018
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Failure on Appveyor Master
4 participants