-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Replaced open with Context Mgrs in Parser Tests #21105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just did a search and there are a surprising number of non-context manager |
Codecov Report
@@ Coverage Diff @@
## master #21105 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 153 153
Lines 49497 49497
=======================================
Hits 45456 45456
Misses 4041 4041
Continue to review full report at Codecov.
|
@alysivji are those using IO buffers or file handles? If the former I don't think it's a necessity. The latter should definitely be cleaned up |
Is that validated by restarting the failed jobs associated with those? |
oh those were just transient issues |
OK yea figured that was the case. I'm reading this as "wait and see if this issue pops back up again" so doing nothing for now, but if I'm missing something let me know |
yep - nothing to do now |
(cherry picked from commit ed784a8)
(cherry picked from commit ed784a8)
Maybe closes #21102 and #19984, though if not should still work as a general cleanup