CLN: Refactor open into context manager in io tests #21139
Conversation
| fh = open(p, 'wb') | ||
| fh.write(s) | ||
| fh.close() | ||
| with open(p, 'wb') as fh: |
There was a problem hiding this comment.
Do we have a name used more often than not for the file handle? I notice in this change we have two different ones. The last file I touched they were all as f: - if that's used more often than not then let's update these to stay consistent
There was a problem hiding this comment.
@WillAyd : I think this is one of those gray areas where consistency and semantics are somewhat at odds. It's true that using as f would render it consistent, but names like outfile (as below) have their merit as providing more information about the file's usage.
Codecov Report
@@ Coverage Diff @@
## master #21139 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 153 153
Lines 49499 49499
=======================================
Hits 45460 45460
Misses 4039 4039
Continue to review full report at Codecov.
|
|
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diffBuilding on #21105 by @WillAyd, I cleaned up some more
openstatements.