Skip to content

CI: Failure on Appveyor Master #21102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAugspurger opened this issue May 17, 2018 · 5 comments · Fixed by #21105
Closed

CI: Failure on Appveyor Master #21102

TomAugspurger opened this issue May 17, 2018 · 5 comments · Fixed by #21105
Labels
CI Continuous Integration Windows Windows OS
Milestone

Comments

@TomAugspurger
Copy link
Contributor

https://ci.appveyor.com/project/pandas-dev/pandas/build/job/0y6fvce0al2yax06?fullLog=true#L1989

cc @WillAyd

Maybe #21066 was related? Not sure how though. Looking now.

@TomAugspurger TomAugspurger added CI Continuous Integration Windows Windows OS labels May 17, 2018
@TomAugspurger TomAugspurger added this to the 0.23.1 milestone May 17, 2018
@WillAyd
Copy link
Member

WillAyd commented May 17, 2018

Hmm strange indeed. I have a hard time thinking that change would be the cause (it was passing fine up until the last commit) but who knows.

I recall there being a similar issue with the Mac builds and in the same area of testing (see #19984). I'm not sure there was ever a real resolution to that one outside of time (?)

No chance we changed anything with the build environment right? I see other changes are passing...

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented May 17, 2018 via email

@WillAyd
Copy link
Member

WillAyd commented May 17, 2018

I did notice there's one instance in common.py where we open a file handle but never explicitly close it. It's tough to say since any information about the ResourceWarning is getting suppressed but wonder if the below line is the offender?

handle = open(self.csv_shiftjs, "rb")

@jreback
Copy link
Contributor

jreback commented May 17, 2018

that looks like an issue (independent of other things)

@david-liu-brattle-1
Copy link
Contributor

david-liu-brattle-1 commented May 19, 2018

I think I got the same problem in #21111 (Commit #ce02a40)
https://ci.appveyor.com/project/pandas-dev/pandas/build/1.0.14243/job/c3wslf40egfq4ksw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Windows Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants