BUG: fillna maximum recursion depth exceeded in cmp (GH18159). #18385

ghost · 2017-11-20T13:08:57Z

closes BUG: fillna maximum recursion depth exceeded in cmp #18159
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

TomAugspurger · 2017-11-20T13:36:49Z

doc/source/whatsnew/v0.22.0.txt

@@ -94,6 +94,7 @@ Documentation Changes
 Bug Fixes
 ~~~~~~~~~

+- BUG: fillna maximum recursion depth exceeded in cmp (GH18159).


Format the issue like

:issue:`18159`

so that the link is rendered;.

Also, you can move this to 0.21.1 since it's a bugfix.

codecov · 2017-11-20T14:12:57Z

Codecov Report

Merging #18385 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18385      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.02%     
==========================================
  Files         164      164              
  Lines       49718    49718              
==========================================
- Hits        45426    45417       -9     
- Misses       4292     4301       +9

Flag	Coverage Δ
#multiple	`89.14% <100%> (ø)`	⬆️
#single	`39.61% <100%> (-0.07%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/internals.py	`94.54% <100%> (ø)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.8% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1647a72...7380624. Read the comment docs.

codecov · 2017-11-20T14:12:59Z

Codecov Report

Merging #18385 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #18385      +/-   ##
==========================================
+ Coverage   91.58%   91.58%   +<.01%     
==========================================
  Files         153      153              
  Lines       51250    51250              
==========================================
+ Hits        46935    46938       +3     
+ Misses       4315     4312       -3

Flag	Coverage Δ
#multiple	`89.44% <100%> (+0.02%)`	⬆️
#single	`40.67% <100%> (-0.11%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/internals.py	`94.44% <100%> (ø)`	⬆️
pandas/io/gbq.py	`25% <0%> (-58.34%)`	⬇️
pandas/core/frame.py	`97.81% <0%> (-0.1%)`	⬇️
pandas/plotting/_converter.py	`65.25% <0%> (+1.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c04e2...03b2f6b. Read the comment docs.

gfyoung · 2017-11-20T18:30:00Z

doc/source/whatsnew/v0.21.1.txt

@@ -64,6 +64,7 @@ Bug Fixes
 - Bug in ``pd.concat`` when empty and non-empty DataFrames or Series are concatenated (:issue:`18178` :issue:`18187`)
 - Bug in :class:`IntervalIndex` constructor when a list of intervals is passed with non-default ``closed`` (:issue:`18334`)
 - Bug in :meth:`IntervalIndex.copy` when copying and ``IntervalIndex`` with non-default ``closed`` (:issue:`18339`)
+- Bug in :meth:`fillna` maximum recursion depth exceeded in cmp (:issue:`18159`).


"where maximum recursion depth gets exceeded"

Also, instead of "cmp", replace it with something more reader-friendly (I presume this is comparison?)

jreback · 2017-11-21T00:47:31Z

pandas/core/internals.py

-                not isinstance(element, (bool, np.bool_, datetime, timedelta,
+        return (
+            isinstance(element, (float, int, np.floating, np.int_, np.long))
+            and not isinstance(element, (bool, np.bool_, datetime, timedelta,


use long from pandas.compat

another location need to be changed

see #18399

jreback · 2017-11-22T02:14:03Z

can you rebase

gkonefal-reef · 2017-11-23T09:56:13Z

I've implemented changes you've requested.

jreback · 2017-11-23T15:52:14Z

doc/source/whatsnew/v0.21.1.txt

@@ -56,6 +56,8 @@ Documentation Changes

 Bug Fixes
 ~~~~~~~~~
+- Bug in :meth:`fillna` where maximum recursion depth gets exceeded in comparison (:issue:`18159`).


make this friendly from a user perspective, eg. a reader of the release notes should understand that doing X is now fixed.

jreback · 2017-11-23T15:53:50Z

pandas/core/internals.py

-        return (isinstance(element, (float, int, np.floating, np.int_)) and
-                not isinstance(element, (bool, np.bool_, datetime, timedelta,
+        return (
+            isinstance(element, (float, int, np.floating, np.int_, compat.long))


there is another section where you need to add this (in _can_hold_element), in ComplexBlock, also can you add a test which hits that as well

pep8speaks · 2017-12-03T09:19:30Z

Hello @kchomski-reef! Thanks for updating the PR.

In the file pandas/core/internals.py, following are the PEP8 issues :

Line 1853:13: W503 line break before binary operator
Line 1905:13: W503 line break before binary operator

Comment last updated on December 08, 2017 at 16:57 Hours UTC

gkonefal-reef · 2017-12-03T10:18:38Z

Changes applied as requested.

jreback

doc change, ping when green.

jreback · 2017-12-03T16:04:12Z

doc/source/whatsnew/v0.21.1.txt

@@ -56,6 +56,8 @@ Documentation Changes

 Bug Fixes
 ~~~~~~~~~
+- Bug in :meth:`Series.fillna` which was raising RuntimeError when got large integer (:issue:`18159`).


move this to Conversions section.

Bug in :meth:`Series.fillna` which raised when passed a long integer on Python 2

jreback · 2017-12-08T00:03:03Z

can you rebase and fixup

gkonefal-reef · 2017-12-08T22:46:52Z

checks green

jreback · 2017-12-09T00:27:15Z

thanks @gkonefal-reef

…s-dev#18385) (cherry picked from commit 27a64b2)

(cherry picked from commit 27a64b2)

TomAugspurger reviewed Nov 20, 2017

View reviewed changes

ghost force-pushed the 18159 branch from 54303dd to 7380624 Compare November 20, 2017 14:12

gfyoung added 2/3 Compat Bug Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Nov 20, 2017

gfyoung reviewed Nov 20, 2017

View reviewed changes

jreback mentioned this pull request Nov 21, 2017

BUG: Fix Python2 long unsupport in _can_hold_element #18399

Closed

4 tasks

jreback requested changes Nov 21, 2017

View reviewed changes

gkonefal-reef force-pushed the 18159 branch 3 times, most recently from c21485f to 7474a3b Compare November 22, 2017 19:28

jreback requested changes Nov 23, 2017

View reviewed changes

gkonefal-reef force-pushed the 18159 branch from 7474a3b to e0aef13 Compare December 3, 2017 09:19

jreback added this to the 0.21.1 milestone Dec 3, 2017

jreback added the Needs Backport label Dec 3, 2017

jreback requested changes Dec 3, 2017

View reviewed changes

gkonefal-reef force-pushed the 18159 branch 3 times, most recently from fe7360c to ef61aa4 Compare December 5, 2017 13:26

gkonefal-reef added 3 commits December 5, 2017 22:53

BUG: fillna maximum recursion depth exceeded in cmp (GH18159).

b288d19

Applied requested changes

ac45112

Moved change log to conversions section

68a5f5e

gkonefal-reef force-pushed the 18159 branch from ef61aa4 to 68a5f5e Compare December 5, 2017 21:56

jreback removed this from the 0.21.1 milestone Dec 8, 2017

Lint fixes

03b2f6b

jreback added this to the 0.21.1 milestone Dec 9, 2017

jreback approved these changes Dec 9, 2017

View reviewed changes

jreback merged commit 27a64b2 into pandas-dev:master Dec 9, 2017

Licht-T mentioned this pull request Dec 9, 2017

RecursionError when passing long to fillna #18316

Closed

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 11, 2017

BUG: fillna maximum recursion depth exceeded in cmp (GH18159). (panda…

d8d0104

…s-dev#18385) (cherry picked from commit 27a64b2)

TomAugspurger mentioned this pull request Dec 11, 2017

Backports round 2 #18732

Merged

TomAugspurger pushed a commit that referenced this pull request Dec 12, 2017

BUG: fillna maximum recursion depth exceeded in cmp (GH18159). (#18385)

3e4a3dd

(cherry picked from commit 27a64b2)

TomAugspurger removed the Needs Backport label Dec 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: fillna maximum recursion depth exceeded in cmp (GH18159). #18385

BUG: fillna maximum recursion depth exceeded in cmp (GH18159). #18385

ghost commented Nov 20, 2017

TomAugspurger Nov 20, 2017

ghost Nov 20, 2017

codecov bot commented Nov 20, 2017

codecov bot commented Nov 20, 2017 •

edited

Loading

gfyoung Nov 20, 2017

jreback Nov 21, 2017

jreback Nov 21, 2017

jreback commented Nov 22, 2017

gkonefal-reef commented Nov 23, 2017

jreback Nov 23, 2017

jreback Nov 23, 2017

pep8speaks commented Dec 3, 2017 •

edited

Loading

gkonefal-reef commented Dec 3, 2017

jreback left a comment

jreback Dec 3, 2017

jreback commented Dec 8, 2017

gkonefal-reef commented Dec 8, 2017

jreback commented Dec 9, 2017

BUG: fillna maximum recursion depth exceeded in cmp (GH18159). #18385

BUG: fillna maximum recursion depth exceeded in cmp (GH18159). #18385

Conversation

ghost commented Nov 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 20, 2017

Codecov Report

codecov bot commented Nov 20, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Nov 22, 2017

gkonefal-reef commented Nov 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pep8speaks commented Dec 3, 2017 • edited Loading

Comment last updated on December 08, 2017 at 16:57 Hours UTC

gkonefal-reef commented Dec 3, 2017

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Dec 8, 2017

gkonefal-reef commented Dec 8, 2017

jreback commented Dec 9, 2017

codecov bot commented Nov 20, 2017 •

edited

Loading

pep8speaks commented Dec 3, 2017 •

edited

Loading