Skip to content

Commit c21485f

Browse files
committed
Issue 18159 review applied
1 parent 201ec19 commit c21485f

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

doc/source/whatsnew/v0.21.1.txt

+1-9
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,7 @@ Documentation Changes
5656

5757
Bug Fixes
5858
~~~~~~~~~
59-
- Bug in ``DataFrame.resample(...).apply(...)`` when there is a callable that returns different columns (:issue:`15169`)
60-
- Bug in :class:`TimedeltaIndex` subtraction could incorrectly overflow when ``NaT`` is present (:issue:`17791`)
61-
- Bug in :class:`DatetimeIndex` subtracting datetimelike from DatetimeIndex could fail to overflow (:issue:`18020`)
62-
- Bug in ``pd.Series.rolling.skew()`` and ``rolling.kurt()`` with all equal values has floating issue (:issue:`18044`)
63-
- Bug in ``pd.DataFrameGroupBy.count()`` when counting over a datetimelike column (:issue:`13393`)
64-
- Bug in ``pd.concat`` when empty and non-empty DataFrames or Series are concatenated (:issue:`18178` :issue:`18187`)
65-
- Bug in :class:`IntervalIndex` constructor when a list of intervals is passed with non-default ``closed`` (:issue:`18334`)
66-
- Bug in :meth:`IntervalIndex.copy` when copying and ``IntervalIndex`` with non-default ``closed`` (:issue:`18339`)
67-
- Bug in :meth:`fillna` maximum recursion depth exceeded in cmp (:issue:`18159`).
59+
- Bug in :meth:`fillna` where maximum recursion depth gets exceeded in comparison (:issue:`18159`).
6860

6961

7062
Conversion

pandas/core/internals.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1848,7 +1848,7 @@ def _can_hold_element(self, element):
18481848
return (issubclass(tipo.type, (np.floating, np.integer)) and
18491849
not issubclass(tipo.type, (np.datetime64, np.timedelta64)))
18501850
return (
1851-
isinstance(element, (float, int, np.floating, np.int_, np.long))
1851+
isinstance(element, (float, int, np.floating, np.int_, compat.long))
18521852
and not isinstance(element, (bool, np.bool_, datetime, timedelta,
18531853
np.datetime64, np.timedelta64)))
18541854

0 commit comments

Comments
 (0)