Skip to content

Backports round 2 #18732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 12, 2017
Merged

Conversation

TomAugspurger
Copy link
Contributor

No description provided.

jbrockmendel and others added 8 commits December 11, 2017 14:32
* patquet.py: Add error message for no engine found

Give a better error message for engine="auto" case when none of the
engines were found installed.

* clean-up to prevent merge conflicts with other PR

(cherry picked from commit b8b108c)
)

fastparquet automatically names an index 'index' if it doesn't
already have a name

(cherry picked from commit 8d7e876)
@pep8speaks
Copy link

pep8speaks commented Dec 11, 2017

Hello @TomAugspurger! Thanks for updating the PR.

Line 1843:13: W503 line break before binary operator
Line 1895:13: W503 line break before binary operator

Comment last updated on December 11, 2017 at 21:06 Hours UTC

@TomAugspurger
Copy link
Contributor Author

Hmm, not sure why those linting errors are coming up here, but not in #18385.

@jorisvandenbossche
Copy link
Member

Because W503 was added to setup.cfg as ignored error code on master

@jorisvandenbossche
Copy link
Member

See #18046 (comment). Maybe add a commit that adds it here as well

@jorisvandenbossche
Copy link
Member

and I merged #18730

@TomAugspurger
Copy link
Contributor Author

Ah thanks. Yes, I'll just make a new commit then I think.

jorisvandenbossche and others added 2 commits December 11, 2017 15:04
* DOC: fix options table

* additional fix

(cherry picked from commit 8e34ec8)
@codecov
Copy link

codecov bot commented Dec 12, 2017

Codecov Report

Merging #18732 into 0.21.x will decrease coverage by 0.03%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.21.x   #18732      +/-   ##
==========================================
- Coverage   91.33%   91.29%   -0.04%     
==========================================
  Files         156      156              
  Lines       51807    51835      +28     
==========================================
+ Hits        47316    47322       +6     
- Misses       4491     4513      +22
Flag Coverage Δ
#multiple 89.17% <60%> (-0.03%) ⬇️
#single 40.15% <30%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/datetimelike.py 97.1% <100%> (ø) ⬆️
pandas/io/formats/format.py 96.1% <100%> (+0.14%) ⬆️
pandas/core/internals.py 94.47% <100%> (ø) ⬆️
pandas/core/indexes/timedeltas.py 91.15% <100%> (ø) ⬆️
pandas/io/pytables.py 92.84% <100%> (ø) ⬆️
pandas/core/indexes/datetimes.py 95.57% <100%> (-0.1%) ⬇️
pandas/io/parquet.py 60.19% <60.86%> (-5.2%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bede1a...37f954a. Read the comment docs.

@jreback jreback added this to the 0.21.1 milestone Dec 12, 2017
@jreback
Copy link
Contributor

jreback commented Dec 12, 2017

lgtm.

@TomAugspurger TomAugspurger merged commit 64e565a into pandas-dev:0.21.x Dec 12, 2017
@TomAugspurger TomAugspurger deleted the backports-round-2 branch December 12, 2017 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants