TST: fix assert_categorical_equal message #13080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Testing
sinhrks
force-pushed
the
test_categorical_message
branch
from
35f1a53 to
1a5cc27
Compare
| assert_index_equal(res.categories, exp.categories) | ||
| assert_index_equal(left.categories, right.categories, | ||
| obj='{0}.categories'.format(obj)) | ||
| assert_numpy_array_equal(left.codes, right.codes, |
There was a problem hiding this comment.
In [2]: tm.assert_numpy_array_equal(np.array([1,2],dtype='int64'),np.array([1,2],dtype='int8'))
Out[2]: True
check the dtypes are equal as well (in fact we might want to do that in assert_numpy_array_equal)
There was a problem hiding this comment.
Will split this to other PR as there are lots of failures (unrelated to categorical).
sinhrks
force-pushed
the
test_categorical_message
branch
3 times, most recently
from
ef83608 to
ee0f652
Compare
3 tasks
sinhrks
changed the title
sinhrks
force-pushed
the
test_categorical_message
branch
2 times, most recently
from
6f48d79 to
91ccb3c
Compare
sinhrks
changed the title
sinhrks
force-pushed
the
test_categorical_message
branch
from
91ccb3c to
81172ce
Compare
| @@ -985,7 +985,7 @@ def __setstate__(self, state): | |||
|
|
|||
| # Provide compatibility with pre-0.15.0 Categoricals. | |||
| if '_codes' not in state and 'labels' in state: | |||
| state['_codes'] = state.pop('labels') | |||
| state['_codes'] = state.pop('labels').astype(np.int8) | |||
There was a problem hiding this comment.
Minor fix to make dtype compat. Needs whatsnew?
|
ty sir! |
2 tasks
jreback
pushed a commit
that referenced
this pull request
Jul 5, 2016
follow up for #13080 to use `_coerce_indexer_dtype`. Author: sinhrks <[email protected]> Closes #13426 from sinhrks/cat_pickle and squashes the following commits: e8702f8 [sinhrks] BUG: categorical unpickle to use _coerce_indexer_dtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThis must be after #13088.