TST: Check ndarray dtype by default #13088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Testing
4 tasks
Current coverage is 84.14%@@ master #13088 diff @@
==========================================
Files 137 137
Lines 50261 50238 -23
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42288 42270 -18
+ Misses 7973 7968 -5
Partials 0 0
|
|
failing here: https://travis-ci.org/pydata/pandas/jobs/127978632 |
| np.array(["a", "b", "c"])) | ||
|
|
||
| exp_cat = np.array(["a", "b", "c", "a"], dtype=np.object_) | ||
| self.assert_numpy_array_equal(cat.__array__(), exp_cat) |
There was a problem hiding this comment.
can do in a followup, but I suspect some of these tests would be more clear to construct the expected Categorical and use assert_equal_categorical (when these were originally written we didn't hav e it).
2 tasks
| na, nb = a.size, b.size | ||
| if a.shape != b.shape: | ||
| from pandas.util.testing import raise_assert_detail | ||
| raise_assert_detail(obj, '{0} shapes are different'.format(obj), | ||
| a.shape, b.shape) | ||
|
|
||
| if check_dtype and a.dtype != b.dtype: |
sinhrks
force-pushed
the
test_array_dtype
branch
2 times, most recently
from
08950d0 to
714a1ad
Compare
|
thanks @sinhrks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffAlso did little cleanup of
testing.pyxandtesting.py.