BUG: categorical unpickle to use _coerce_indexer_dtype #13426
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should show up in tests I think for an older pickle (I don't recall when we started coercing the codes), but not really a big deal. |
|
can you add a test, or do we have coverage? |
Current coverage is 84.34%@@ master #13426 diff @@
==========================================
Files 138 138
Lines 51126 51126
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43122 43121 -1
- Misses 8004 8005 +1
Partials 0 0
|
|
No, added some pickles to test it. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --difffollow up for #13080 to use
_coerce_indexer_dtype.