-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Typo(s?) in pandas.DataFrame.isin #43755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@loucadufault I am not able to find out the exact location of the file that needs to be fixed. Can you tell me what is the location of this file? I tried finding it through this link https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.isin.html but wasn't able to spot the relevant folders. |
@Varun270 The file is frame.py. If you want to fix it I'll leave it to you. Otherwise, I can. |
|
Yeah, I would love to fix this issue. Thanks !!! |
take |
@MarcoGorelli I have pushed the changes but somehow instead of pushing it from Development ----> Master. I pushed it from Development ----> Development. Development is a branch that I made. what should I do now to fix this delete the previous commit and again create a PR? |
you can make a new branch - I recommend the first 3 chapters of this book for getting familiar with the git workflow |
@Varun270 Just follow the "contributing" instructions to the letter. Yes, there is a bit of a learning curve... I suggest that you change your change slightly. You say "Note that 'falcon' does not match based on the number of legs in other." I would change to:
Then you will indeed get the falcon not matching:
|
This reverts commit 11f27df.
master
hereLocation of the documentation
https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.isin.html
Documentation problem
In the last example, the text introducing the code snippet reads:
However, "df2" does not exist in the included code snippet (it is instead called "other").
Additionally, I am not comfortable enough with pandas to assert this, but it seems like the text should incorrectly states that "falcon" does not match, since "falcon" indeed does match for both columns, see the relevant portion of the code snippet:
Suggested fix for documentation
Text should at least read:
or the variable in the code snippet should be renamed to "df2".
Additionally, something may need to be done to address the potential discrepancy in saying that "falcon" does not match.
The text was updated successfully, but these errors were encountered: