DOC: Typo(s?) in pandas.DataFrame.isin #43820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Varun270
commented
Sep 30, 2021
Varun270
commented
- [🗸] closes DOC: Typo(s?) in pandas.DataFrame.isin #43755
- [🗸] tests added / passed
- [🗸] Ensure all linting tests pass, see here for how to run them
- [🗸] whatsnew entry
jreback
changed the title
jreback
reviewed
Sep 30, 2021
pandas/core/frame.py
Outdated
| ... index=['spider', 'falcon']) | ||
| >>> df.isin(other) | ||
| num_legs num_wings | ||
| falcon True True | ||
| falcon False True |
There was a problem hiding this comment.
nitpick can you line these up (as would happen in the terminal)
There was a problem hiding this comment.
Do you want me to adjust True and False in line 10572?
There was a problem hiding this comment.
I think jeff means deleting one whitespace between falcon and false
There was a problem hiding this comment.
Understood , I am force pushing the suggested changes
|
@jreback I did the changes you suggested, you can review them. |
|
thanks @Varun270 |
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.