Added "." on to check_dtype and obj parameter #44446
Conversation
|
can you merge master |
pandas/core/frame.py
Outdated
|
|
||
| >>> other = pd.DataFrame({'num_legs': [8, 2], 'num_wings': [0, 2]}, | ||
| >>> other = pd.DataFrame({'num_legs': [8, 3], 'num_wings': [0, 2]}, |
There was a problem hiding this comment.
I didn't change these lines actually I only added the "." at the end of description of "check_dtype" and "obj". These changes are from a different issue that I solved and my PR got merged but I have no idea why these commits got pushed with this PR. You can have a look at this PR for better understanding - https://github.com/pandas-dev/pandas/pull/43820/files
There was a problem hiding this comment.
Do let me know what would I have to do in order to get rid of these extra commits.
There was a problem hiding this comment.
Simply revert the relevant commit on your branch
There was a problem hiding this comment.
something like
git fetch upstream
git rebase upstream/master
git push origin HEAD -f
There was a problem hiding this comment.
Done! Kindly review it again.
This reverts commit 11f27df.
|
Thanks @Varun270 - next time I'd advise to make a new branch for each issue you try to solve |
Noted, I Will keep it in mind! |
From #28602
pandas.testing.assert_categorical_equal: Parameter "check_dtype" description should finish with "." pandas.testing.assert_categorical_equal: Parameter "obj" description should finish with "."