Extends DataFrame.groupby overloads to recognize some scalar index types
#679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initially I had also added the Series version of each Index to the type unions and added a separate new test for those, however it seems a little less useful, since you would have to use the series from the dataframe, which does not have a specific type, so you would need to manually cast to a more specific type to get the benefit there. It certainly can be done, but it felt so awkward writing the test that I decided against it for now. It's also not a pattern I personally have ever used before on a groupby. This also decreases the surface area of the patch, so it should be a less controversial change overall. |
Daverball
changed the title
DataFrame.groupby overloads to recognize some scalar index types
twoertwein
reviewed
May 5, 2023
Dr-Irv
requested changes
May 5, 2023
Dr-Irv
reviewed
May 5, 2023
Add additional overloads to `DataFrame.groupby` to cover all index types
Dr-Irv
requested changes
May 6, 2023
Dr-Irv
approved these changes
May 6, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.groupbyshould return_DataFrameGroupByScalarwhen grouping by a PeriodIndex #674assert_type()to assert the type of any return value