Skip to content

Refactors Series.groupby to match DataFrame.groupby #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 10, 2023

Conversation

Daverball
Copy link
Contributor

@Daverball Daverball commented May 10, 2023

@Daverball
Copy link
Contributor Author

Daverball commented May 10, 2023

I also lifted Index out of GroupByObjectNonScalar to avoid the unsafe overload errors and to get rid of one of the redundant overloads in DataFrame.groupby.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice contribution. Can you try np.integer rather than using astype(np.int64) ?

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Daverball

@Dr-Irv Dr-Irv merged commit 002f0cc into pandas-dev:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants