Skip to content

Specify the color space (sRGB) in all numpy.org CSS files #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 16, 2021
Merged

Specify the color space (sRGB) in all numpy.org CSS files #457

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
85e321c
Specify the color space (sRGB) in all numpy.org CSS files
aerikpawson Mar 2, 2021
16f60fd
Merge branch 'numpy:master' into aerikpawson-specify-color-space-css-…
aerikpawson Jul 30, 2021
7833df7
Revert "Specify the color space (sRGB) in all numpy.org CSS files"
aerikpawson Jul 30, 2021
65f599c
Specify the color space in RGB
aerikpawson Jul 30, 2021
8ab15ef
Specify the color space in RGB
aerikpawson Jul 30, 2021
da43482
Specify the color space in RGB
aerikpawson Jul 30, 2021
3952983
Specify the color space in RGB
aerikpawson Jul 30, 2021
b8b697a
Specify the color space in RGB
aerikpawson Jul 30, 2021
21a450f
Specify the color space in RGB
aerikpawson Jul 30, 2021
cec4bc4
Specify the color space in RGB
aerikpawson Jul 30, 2021
4baa6db
Fix inconsistent formatting
aerikpawson Jul 30, 2021
9b5812e
Fix inconsistant formating
aerikpawson Jul 30, 2021
54925f3
Specify the color space in RGB
aerikpawson Jul 31, 2021
702ed14
Specify the NumPy color palette in rgb
aerikpawson Jul 31, 2021
120811d
Specify the color space in rgb. Fix inconsistent formatting
aerikpawson Jul 31, 2021
abbb5d4
Remove the space.
aerikpawson Aug 4, 2021
fd28341
Add the new names of the colors in the existing website palette
aerikpawson Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions static/css/casestudies.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
}

.casestudies a {
color: #013243 !important;
color: rgb(1, 50, 67) !important;
}

.casestudies-box-title {
Expand Down Expand Up @@ -74,7 +74,7 @@
left: 0;
right: 100%;
bottom: 0;
background: #013243;
background: rgb(1, 50, 67);
height: 4px;
-webkit-transition-property: right;
transition-property: right;
Expand All @@ -86,4 +86,4 @@

.casestudies-underline:hover:before, .casestudies-underline:focus:before, .casestudies-underline:active:before {
right: 0;
}
}
6 changes: 3 additions & 3 deletions static/css/content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
}

.content-container .divider {
background: #013243;
background: rgb(1, 50, 67);
}

.content-container h2 {
Expand All @@ -61,7 +61,7 @@

#shortcuts {
margin-top: 10px;
border-left: 1px solid #013243;
border-left: 1px solid rgb(1, 50, 67);
}

.shortcuts-H2 {
Expand All @@ -86,4 +86,4 @@
.shortcuts-container {
display: none;
}
}
}
2 changes: 1 addition & 1 deletion static/css/keyfeatures.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
}

.keyfeatures-box-text > a {
color: #4D77CF;
color: rgb(77, 119, 207);
}

.keyfeatures-box-text {
Expand Down
8 changes: 4 additions & 4 deletions static/css/news.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@
align-items: center;
width: 100vw;
min-height: 45px;
background-color: #013243;
color: white;
background-color: rgb(1, 50, 67);
color: rgb(255, 255, 255);
white-space: nowrap;
}

.news-container a {
color: white;
color: rgb(255, 255, 255);
}

.news-container a:hover {
color: white;
color: rgb(255, 255, 255);
}

.news-title {
Expand Down
18 changes: 9 additions & 9 deletions static/css/shell.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
justify-content: center;
width: 100vw;
min-height: 455px;
background-color: #EEEEEE;
background-color: rgb(238, 238, 238);
}

.numpy-shell-container {
Expand Down Expand Up @@ -79,8 +79,8 @@
text-transform: uppercase;
letter-spacing: 1.5px;
font-weight: 500;
color: black;
background-color: #EEEEEE;
color: rgb(0,0,0);
background-color: rgb(238, 238, 238);
border: none;
border-radius: 25px;
outline: none;
Expand Down Expand Up @@ -122,9 +122,9 @@
min-width: 500px;
margin: 15px;
padding: 0 17px;
color: #FFFFFF;
color: rgb(255 ,255 ,255);
overflow: auto;
background-color: #013243;
background-color: rgb(1, 50, 67);
font-family: 'Source Code Pro', monospace;
}

Expand All @@ -137,11 +137,11 @@
}

.CodeMirror pre {
color: #FFFFFF !important;
color: rgb(255, 255, 255) !important;
}

.CodeMirror-cursor {
color: #FFFFFF !important;
color: rgb(255, 255, 255) !important;
border-left: 1px solid white !important;
}

Expand All @@ -160,8 +160,8 @@
text-transform: uppercase;
letter-spacing: 1.5px;
font-weight: 500;
color: black;
background-color: #EEEEEE;
color: rgb(0,0,0);
background-color: rgb(238 ,238 ,238);
border: none;
border-radius: 25px;
outline: none;
Expand Down
52 changes: 26 additions & 26 deletions static/css/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
/* NumPy Color Palette */
/* #FFC553 Mustard */
/* #4DABCF Maximum Blue */
/* #4D77CF Han Blue */
/* #FFFFFF White */
/* #EEEEEE Isabelline */
/* #6C7A89 Aurometalsaurus */
/* #013243 Warm Black */
/* rgb(255, 197, 83) */
/* rgb(77, 171, 207) */
/* rgb(77, 119, 207) */
/* rgb(255, 255, 255) */
/* rgb(238, 238, 238) */
/* rgb(108, 122, 137) */
/* rgb(1, 50, 67) */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it's really nice to add a description here for each color-- I don't have any idea what each of these are, and it will be easier to use them in the future if we know which one is the blue one, for example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelachance It’s a fair point. The issue with the current color names is that some of them have been assigned to a different RGB since we selected the color palette for numpy.org. (For more context, refer to #405 (comment).) This is bound to cause confusion.

What do you think of naming the palette as follows:
rgb(255, 197, 83) NumPy Yellow (or NumPy Mustard)
rgb(77, 171, 207) NumPy Ndarray Blue
rgb(77, 119, 207) NumPy Deep Blue
rgb(255, 255, 255) White
rgb(238, 238, 238) NumPy Cloud Gray
rgb(108, 122, 137) NumPy Slate Gray
rgb(1, 50, 67) NumPy Warm Black

@joelachance and everyone else, feel free to suggest your names for the color palette.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like them! I think any color description that's close to the color is 'good enough'. Developers will easily know what color they're using with any description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelachance Great!
@aerikpawson Please incorporate the suggested above into your PR.


body {
font-family: 'Lato', sans-serif;
}

em {
color: black !important;
color: rgb(0, 0, 0) !important;
}

.flex-row {
Expand Down Expand Up @@ -58,7 +58,7 @@ em {
font-family: 'Lato', sans-serif;
font-weight: 900;
font-size: 6em;
color: #013243;
color: rgb(1, 50, 67);
}

.hero-logo {
Expand All @@ -82,8 +82,8 @@ em {
text-transform: uppercase;
letter-spacing: 1.5px;
font-weight: 500;
color:#FFFFFF;
background-color: #013243;
color:rgb(255, 255, 255);
background-color: rgb(1, 50, 67);
border: none;
border-radius: 25px;
outline: none;
Expand All @@ -93,19 +93,19 @@ em {
}

#navbar-item {
color: #013243;
color: rgb(1, 50, 67);
text-decoration: none;
}

#navbar-item:hover {
color: #4DABCF !important;
color: rgb(77, 171, 207) !important;
}

#feature-card {
height: 475px;
}
#backtotop.visible #backtotop-color:hover {
background: #ffc553;
background: rgb(255, 197, 83);
}

.mt-30 {
Expand Down Expand Up @@ -180,7 +180,7 @@ p {

/* Footer */
#footer {
background-color: #013243;
background-color: rgb(1, 50, 67);
}

.footer-logo-column {
Expand All @@ -203,7 +203,7 @@ p {

.footer-link, .footer-link:hover {
font-size: 1rem;
color: #EEEEEE;
color: rgb(238, 238, 238);
}

.footer-actions {
Expand All @@ -217,7 +217,7 @@ p {

.footer-actions p {
margin: 0;
color: #EEEEEE;
color: rgb(238, 238, 238);
}

.sign-up-container {
Expand All @@ -230,27 +230,27 @@ p {

.sign-up-image {
padding: 5px 10px 6px 10px;
border-right: 1px solid #EEEEEE;
background-color: #EEEEEE;
border-right: 1px solid rgb(238, 238, 238);
background-color: rgb(238, 238, 238);
border-radius: 5px 0 0 5px;
}

.sign-up-input {
background-color: white;
background-color: rgb(238, 238, 238);
border-radius: 0 5px 5px 0;
border: none;
width: 75%;
height: 35px;
padding-left: 5px;
font-size: 14px;
color: #013243;
color: rgb(1, 50, 67);
}

.submission-instructions {
position: absolute;
right: 18%;
font-size: 10px;
color: #6c7a89;
color: rgb(108, 122, 137);
}

.signup-button {
Expand All @@ -260,7 +260,7 @@ p {
.thank-you {
display: none;
height: 75px;
color: #EEEEEE;
color: rgb(238, 238, 238);
align-items: center;
}

Expand All @@ -270,7 +270,7 @@ p {

.copyright {
font-size: 12px;
color: #EEEEEE;
color: rgb(238, 238, 238);
}

figcaption {
Expand All @@ -295,7 +295,7 @@ blockquote {

blockquote p {
padding: 15px;
background: #EEEEEE;
background: rgb(238, 238, 238);
border-radius: 5px;
}

Expand Down Expand Up @@ -347,7 +347,7 @@ blockquote p::after {
border-radius: 5px;
margin-left: 5px;
width: 60px;
color: black;
color: rgb(0, 0, 0);
border:none;
outline:none;
}
Expand Down
10 changes: 5 additions & 5 deletions static/css/tabs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
text-transform: uppercase;
letter-spacing: 1.5px;
font-weight: 500;
color: #6C7A89;
color: rgb(108, 122, 137);
}

#tabs-content > li {
Expand Down Expand Up @@ -85,8 +85,8 @@
}

.image-grid > div {
background-color: #EEEEEE;
border: 2px solid #FFFFFF;
background-color: rgb(238, 238, 238);
border: 2px solid rgb(255, 255, 255);
border-radius: 10px;
padding: 10px;
}
Expand All @@ -102,7 +102,7 @@ td > a {
}

tr.highlight-th {
border-top: 1px solid #EEEEEE;
border-top: 1px solid rgb(238, 238, 238);
font-size: 0.8rem;
}

Expand Down Expand Up @@ -134,7 +134,7 @@ td.full-center-text {
td.lastrow-center-text {
text-align: center;
line-height: 35%;
border-bottom: 1px solid #EEEEEE;
border-bottom: 1px solid rgb(255, 255, 255);
}

/* Array Libraries */
Expand Down