Specify RGB values in the docs regarding the NumPy website color palette #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying RGB values in the docs regarding the NumPy website color palette.
rgommers
reviewed
Mar 13, 2021
There was a problem hiding this comment.
Thanks for tackling this issue @aerikpawson!
The added RGB values all look good. It would be nice to keep the color names I think. Is there a reason why you removed them?
|
@rgommers The names of the colors were removed not to mislead users since these names can change. For example, the color with the RGB value of 1/50/67, originally known as “Warm Black”, is now called “Gunmetal”; the color with the RGB value of 238/238/238, formerly known as “Isabelline”, can be found named as “Cultured” or “Whisper” depending on what sources you use. |
|
Ah okay, fair enough - thanks for the explanation. Merging then. Thanks again @aerikpawson |
|
Cool. Thank you, @rgommers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying RGB values in the docs regarding the NumPy website color palette. Addresses part of gh-398.