Specify the color space (sRGB) in all numpy.org CSS files #457
Conversation
This reverts commit 85e321c.
Specifying the color space in RGB.
Specifying the color space in RGB.
Specifying the color space in RGB.
Specifying the color space in RGB.
Specifying the color space in RGB.
Specifying the color space in RGB.
Specifying the color space in RGB.
Fixing inconsistent formatting.
Fixing inconsistant formating.
Specifying the color space in RGB.
Specifying the NumPy color palette in rgb. Fixing inconsistent formatting.
Specifying the color space in rgb. Fixing inconsistent formatting.
aerikpawson
changed the title
|
@aerikpawson LGTM (Looks good to me.) One suggestion: next time, before pushing, squash all the commits you'd like to include in a pull request into one. You’ll have to use the terminal for that. |
static/css/styles.css
Outdated
| /* rgb(255, 197, 83) */ | ||
| /* rgb(77, 171, 207) */ | ||
| /* rgb(77, 119, 207) */ | ||
| /* rgb(255, 255, 255) */ | ||
| /* rgb(238, 238, 238) */ | ||
| /* rgb(108, 122, 137) */ | ||
| /* rgb(1, 50, 67) */ |
There was a problem hiding this comment.
I personally think it's really nice to add a description here for each color-- I don't have any idea what each of these are, and it will be easier to use them in the future if we know which one is the blue one, for example.
There was a problem hiding this comment.
@joelachance It’s a fair point. The issue with the current color names is that some of them have been assigned to a different RGB since we selected the color palette for numpy.org. (For more context, refer to #405 (comment).) This is bound to cause confusion.
What do you think of naming the palette as follows:
rgb(255, 197, 83) NumPy Yellow (or NumPy Mustard)
rgb(77, 171, 207) NumPy Ndarray Blue
rgb(77, 119, 207) NumPy Deep Blue
rgb(255, 255, 255) White
rgb(238, 238, 238) NumPy Cloud Gray
rgb(108, 122, 137) NumPy Slate Gray
rgb(1, 50, 67) NumPy Warm Black
@joelachance and everyone else, feel free to suggest your names for the color palette.
There was a problem hiding this comment.
I like them! I think any color description that's close to the color is 'good enough'. Developers will easily know what color they're using with any description.
There was a problem hiding this comment.
@joelachance Great!
@aerikpawson Please incorporate the suggested above into your PR.
Adding the new names of the colors in the existing website palette. Refer to this discussion: #457 (comment).
@joelachance I don't have the push access to this repo. Please merge this PR when you get a chance. |
Adding the new names of the colors in the existing website palette. Refer to this discussion: #457 (comment).
Fixes #gh-397.