-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-2262 Test Python 3.9 in Evergreen #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -255,7 +255,7 @@ def fallback_encoder(value): | |||
|
|||
class TestBSONTypeEnDeCodecs(unittest.TestCase): | |||
def test_instantiation(self): | |||
msg = "Can't instantiate abstract class .* with abstract methods .*" | |||
msg = "Can't instantiate abstract class" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of outright removing the latter half of this regex, might it be acceptable to use the following instead?
Can't instantiate abstract class .* with abstract method.* .*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't Can't instantiate abstract class
enough to ensure the TypeError is from instantiation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Highlights include: | ||
|
||
- Support for Python 3.9. | ||
- New method :class:`bson.json_util.JSONOptions.with_options`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
@@ -255,7 +255,7 @@ def fallback_encoder(value): | |||
|
|||
class TestBSONTypeEnDeCodecs(unittest.TestCase): | |||
def test_instantiation(self): | |||
msg = "Can't instantiate abstract class .* with abstract methods .*" | |||
msg = "Can't instantiate abstract class" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
f5d5e45
to
fcb6a8e
Compare
Rebased to remove the "PYTHON-2362 Use dnspython<2.0 to avoid timeouts" commit which was already merged. |
This change adds testing for Python 3.9 and fixes:
I've opened https://jira.mongodb.org/browse/PYTHON-2365 and https://jira.mongodb.org/browse/PYTHON-2366 as follow up work to test snappy, FLE, and OCSP. You'll notice this is also based on #484 to get the tests green.