PYTHON-2362 Test with dnspython<2.0 to avoid timeouts #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
changed the title
| if $PYTHON -c 'import dns'; then | ||
| # Trying with/without --user to avoid: | ||
| # ERROR: Can not perform a '--user' install. User site-packages are not visible in this virtualenv. | ||
| $PYTHON -m pip install --upgrade --user 'dnspython<2.0.0' || $PYTHON -m pip install --upgrade 'dnspython<2.0.0' |
There was a problem hiding this comment.
Why not always install without --user?
There was a problem hiding this comment.
Because then we might need sudo. This will just be a temporary workaround until the toolchain is updated.
|
The problem is with Eventlet, right? Probably why no one has complained. |
|
Yes this is an eventlet problem. dnspython 2.0 works fine up until eventlet is imported: >>> from dns import resolver
>>> resolver.query('_mongodb._tcp.test5.test.build.10gen.cc', 'SRV', lifetime=5)
<stdin>:1: DeprecationWarning: please use dns.resolver.resolve() instead
<dns.resolver.Answer object at 0x7fb575599940>
>>> import eventlet
>>> resolver.query('_mongodb._tcp.test5.test.build.10gen.cc', 'SRV', lifetime=5)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/ubuntu/venv/lib/python3.8/site-packages/dns/resolver.py", line 1221, in query
return resolve(qname, rdtype, rdclass, tcp, source,
File "/home/ubuntu/venv/lib/python3.8/site-packages/dns/resolver.py", line 1205, in resolve
return get_default_resolver().resolve(qname, rdtype, rdclass, tcp, source,
File "/home/ubuntu/venv/lib/python3.8/site-packages/dns/resolver.py", line 1043, in resolve
timeout = self._compute_timeout(start, lifetime)
File "/home/ubuntu/venv/lib/python3.8/site-packages/dns/resolver.py", line 950, in _compute_timeout
raise Timeout(timeout=duration)
dns.exception.Timeout: The DNS operation timed out after 5.10618257522583 secondsThis should be fixed by eventlet: eventlet/eventlet#619. |
I don't think this is a massive issue and I'm not sure we should do anything else. eventlet>=0.26.1 was released which pins to |
prashantmital
approved these changes
Sep 11, 2020
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Oct 13, 2020
This reverts commit c549740.
ShaneHarvey
added a commit
that referenced
this pull request
Oct 14, 2020
This reverts commit c549740.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in dnspython 2.0 related to SRV lookups. For now we should downgrade to
dnspython<2.0to get the test suite green.