-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-2262 Test Python 3.9 in Evergreen #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -255,7 +255,7 @@ def fallback_encoder(value): | |
|
||
class TestBSONTypeEnDeCodecs(unittest.TestCase): | ||
def test_instantiation(self): | ||
msg = "Can't instantiate abstract class .* with abstract methods .*" | ||
msg = "Can't instantiate abstract class" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of outright removing the latter half of this regex, might it be acceptable to use the following instead? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
def run_test(base, attrs, fail): | ||
codec = type('testcodec', (base,), attrs) | ||
if fail: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!