This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Mark serial monitor as executable on Mac and Linux #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serial monitor broke on Mac and Linux in v0.4.9 (#1418) for two reasons. One is an issue with extensionless files during VSIX signing, which is temporarily resolved by e0f29b8. The other is because we are now producing the official build on a Windows machine, which is removing the Linux executable bits from the serial monitor executables in the final VSIX. This script manually recreates the archive while setting the appropriate bits on the files that need them.