Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Commit e0f29b8

Browse files
committed
Skip VSIX signing
1 parent b9565c3 commit e0f29b8

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

azure-pipelines.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,13 @@ steps:
121121
solution: .\build\SignVsix.proj
122122
msbuildArguments: /p:SignType=$(SignType)
123123
# MicroBuild signing will always fail on public PRs.
124-
condition: ne(variables['Build.Reason'], 'PullRequest')
124+
# TODO: Signing the VSIX strips out the "main" executables for
125+
# serial-monitor-cli on Mac and Linux, completely breaking serial
126+
# functionality in the extension on these platforms. For now we disable VSIX
127+
# signing because it's not a strict requirement, but we should investigate
128+
# if we can either add extensions to these files or support extensionless
129+
# files in VSIX signing.
130+
condition: and(false, ne(variables['Build.Reason'], 'PullRequest'))
125131
- publish: $(Build.StagingDirectory)\vscode-arduino.vsix
126132
artifact: VS Code extension VSIX
127133
displayName: Publish extension VSIX as artifact

0 commit comments

Comments
 (0)