Improve deployment scripts, make service account JSON configurable by directory, not name #81
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
deploy/setup-project.sh
Outdated
| # restricted permissions to run the gcp_compute_persistent_disk_csi_driver and download | ||
| # the keys to a specified directory | ||
|
|
||
| # WARNING: This script will delete and recreate all service accounts, bindings, and keys. |
There was a problem hiding this comment.
ohoh thats alarming. No just the one set.
| # Args: | ||
| # PROJECT: GCP project | ||
| # GCE_PD_SA_NAME: Name of the service account to create | ||
| # GCE_PD_SA_DIR: Directory to save the service account key |
There was a problem hiding this comment.
Should there be defaults? I think these are all important enough that there shouldn't be any defaults. I have set -o nounset so it throws an error if the vars are unset when the script runs
|
|
||
| # Note: setup-cluster.yaml depends on the existence of cluster-roles | ||
| # system:csi-external-attacher and system:csi-external-provisioner | ||
| # which are in Kubernetes version 1.10.5+ |
There was a problem hiding this comment.
I would put this note in the readme right up top
|
Comments addressed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Fixes: #28
Added some comments to the deployment scripts. JSON is finally configurable by directory, not name.
/assign @msau42